search

apache / incubator-kie-kogito-runtimes

Kogito Runtimes - Kogito is a cloud-native business automation technology for building cloud-ready business applications.
http://kogito.kie.org
Apache License 2.0
491 stars 192 forks source link

[Fix_#3546] NodeInstanceFactoryProvided not included in native build #3548

Closed fjtirado closed 3 weeks ago

fjtirado commented 3 weeks ago

Fix https://github.com/apache/incubator-kie-kogito-runtimes/issues/3546. This is an issue in native build consequence of the refactor done by https://github.com/apache/incubator-kie-kogito-runtimes/pull/3482 I think including the service loader classes should be enough for native compiler to realize it should include all node classes, but @domhanak please let us know if the issue is fixed by this change

fjtirado commented 3 weeks ago

@domhanak Stil not working. It seems more stuff needs to be added. Working on that

fjtirado commented 3 weeks ago

@domhanak Working now, please review

elguardian commented 3 weeks ago

@fjtirado this was fixed in documentation as for service loader it is required

uarkus.native.auto-service-loader-registration

This fixes this classloaders and futures ones. propably it is better solution to add this into an application.properties

fjtirado commented 3 weeks ago

@fjtirado this was fixed in documentation as for service loader it is required

uarkus.native.auto-service-loader-registration

This fixes this classloaders and futures ones. propably it is better solution to add this into an application.properties

Ill try and let you know (Im not sure if setting that property in the quarkus extension automatically scan the META-INF of all dependencies, in which case is indeed a better solution or it just scans the extension one, in which case it wont work)

fjtirado commented 3 weeks ago

Updated to use quarkus property rather than explicitly naming the service loader involved, thanks @elguardian