search

apache / incubator-kie-kogito-serverless-operator

Kubernetes operator for SonataFlow
Apache License 2.0
15 stars 41 forks source link

Knative should not be required to install and run the SonataFlow Operator to deploy workflows #541

Open treblereel opened 1 week ago

treblereel commented 1 week ago

Describe the bug

It looks like starting e91495, e2e are broken, possible because of missed crds:

knative-v1.10.0/eventing-crds.yaml
knative-v1.10.0/eventing-core.yaml

Expected behavior

hack/local/run-e2e.sh passed

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Golang version

1.21.9

Operator-sdk version

No response

SonataFlow Operator version or git rev

No response

Additional information

No response

treblereel commented 1 week ago

kubectl_logs.zip logs_cli.rtf.zip

domhanak commented 6 days ago

+1 most probably we should add something like, during or right after cluster setup:

// Install eventing
kubectl apply -f https://github.com/knative/eventing/releases/download/knative-v1.15.1/eventing-crds.yaml
kubectl apply -f https://github.com/knative/eventing/releases/download/knative-v1.15.1/eventing-core.yaml
// Install serving
kubectl apply -f https://github.com/knative/serving/releases/download/knative-v1.15.2/serving-crds.yaml
kubectl apply -f https://github.com/knative/serving/releases/download/knative-v1.15.2/serving-core.yaml
ricardozanini commented 4 days ago

We should not enforce Knative installation.

ricardozanini commented 4 days ago

@treblereel as a workaround you can run:

make deploy-knative

Before running the e2e tests locally.