search

apache / incubator-kie-tools

Tools for KIE
Apache License 2.0
250 stars 185 forks source link

SVG export creates invalid text-decoration attribute #1408

Open jesse-shaw-egeo opened 1 year ago

jesse-shaw-egeo commented 1 year ago

I'm using VSCode Extension BPMN Editor to create BPMN diagrams. However the SVG contains 'text' nodes with a 'text-decoration' attribute of value "normal" like this:

<text fill="#000000" stroke="none" font-family="Open Sans" font-size="10pt" font-style="normal" font-weight="normal" text-decoration="normal" x="0" y="8.8" text-anchor="start" dominant-baseline="alphabetic">text</text>

As far as I can tell, this is not a specified option. https://www.w3.org/TR/SVG11/text.html#TextDecorationProperties

It's causing my SVG viewer to error out.

Josephblt commented 1 year ago

Here is the PR for this fix: https://github.com/gliffy/canvas2svg/pull/91 After it gets merged, the artifact version needs to be updated here: https://github.com/kiegroup/appformer/blob/ffeb0bd8f4c15e57740baf962ba7a91406edd95f/pom.xml#L70.

yesamer commented 1 year ago

Hey @Josephblt ! Is that repo still maintained? The last (and only) artifact version was released 5 years ago

Josephblt commented 1 year ago

Hello @jesse-shaw-egeo. Unfortunately, @yesamer is right. The project we used to create SVG is no longer maintained. So we now face a more significant challenge to fix this. Would you mind sharing what the editor is and the error you are getting? Thanks.