treblereel commented 3 weeks ago

tests are missed atm, I'll add it in a couple of days

treblereel commented 3 weeks ago

@ricardozanini I have added --minify option to the deploy, it allows us to skip minification if needed By default it's true

ricardozanini commented 2 weeks ago

@domhanak can you please verify this?

domhanak commented 2 weeks ago

@domhanak can you please verify this?

Yup, working on it, investigating some issue with compilation after the minifications, Will let you know.

domhanak commented 1 week ago

Documentation of the command

kn workflow specs help - :heavy_check_mark:
kn workflow specs minify -> this does nothing, and when I do kn workflow specs minify help the result is the same. I think we can better explain the command to the user, in a sense he understands openapi needs to be added as argument to start the minification. For example adding more targeted HELP description here :construction:

Functional

kn workflow specs minify openapi
- Input results in output -> Is that correct? I can see a ConfigMap 01-hello-resources-specs.yaml when deploying but the workflow is failing with compilation errors. :eyes: investigating why :eyes: Cause: Typo in function definition of the workflow, once fixed workflow properly deploys without errors. :heavy_check_mark:
- components are part of the minified file, is that expected? :question:
- file size seems to be larger after minification, according to the message :white_check_mark: Minified file specs/greetingAPI.min.yaml created with 7572 bytes (original size: 6212 bytes)

More information about testing to follow, I will update the comment with latest info. Double checking the scenarios with subflows.