search

apache / incubator-kie-tools

Tools for KIE
Apache License 2.0
252 stars 185 forks source link

kie-tools#2753: Parameterize the groupId of `quarkus-maven-plugin` in "Kogito images" packages #2754

Closed rgdoliveira closed 4 days ago

rgdoliveira commented 5 days ago

Closes https://github.com/apache/incubator-kie-tools/issues/2753

rgdoliveira commented 5 days ago

I'm going to apply the same changes in the suggestions for the other images.

rgdoliveira commented 4 days ago

CI :: Build / run (ubuntu-latest, 1) failing complaining that it did not find the kogitoImagesCekitModules.quarkusGroupId for sonataflow-management-console-image. I will take a look

ricardozanini commented 4 days ago

@tiagobento do you know why all these changes in the pnpm-lock file?

tiagobento commented 4 days ago

@rgdoliveira Honestly, they shouldn't be there I think. I mean, it looks like pnpm rearranged somethings based on previous changes and it didn't revert it when those changes were undone.

My suggestion is that you revert the changes here and bootstrap again, if I'm not mistaken you won't see any changes in it anymore.

rgdoliveira commented 4 days ago

@tiagobento ok, I will remove changes from pnpm-lock file and bootstrap again

rgdoliveira commented 4 days ago

@tiagobento you are right, after bootstraping again there were no changes in pnpm-lock file. I've dropped it from the PR.

rgdoliveira commented 4 days ago

CI is finally green :)

tiagobento commented 4 days ago

Thank you @rgdoliveira. Looks great now! Merging.