apache / incubator-kie-tools

Tools for KIE
Apache License 2.0
252 stars 185 forks source link

kie-issues#208: Renaming any "NamedElement" on the DMN Editor should update all references to the old name #2760

Open danielzhe opened 3 days ago

danielzhe commented 3 days ago

Closes: https://github.com/apache/incubator-kie-issues/issues/208

Some comments about the changes:

Renaming Data Types

https://github.com/user-attachments/assets/865b600d-d15f-44c6-b870-f7e2172175b4

Renaming BKMs and parameters

https://github.com/user-attachments/assets/fb7bf2b6-58f9-4db4-ace6-a5d1e8e2ef0e

General rename

https://github.com/user-attachments/assets/e4485c5a-2285-4bac-9d1c-218edbe052a1

Renaming Included Models name It does not show the confirmation dialog, because doesn't make sense to not update the references in this case, since this already was the default behavior before this PR (when we renamed a included model, we already updated all the references except the expressions, now we update the expressions).

https://github.com/user-attachments/assets/9b44114d-e302-4a09-bd33-81fce5254736

tiagobento commented 3 days ago

Thank you for the PR @danielzhe. It's going to take me a few days to go over everything with the care it deserves. Will keep you posted!

tiagobento commented 13 hours ago

@danielzhe Storybook is pointing to code using ../src because it is used during development. The changes you introduced will make the development experience much worse, requiring us to rebuild stuff after a change, if I'm not mistaken... can you please check?