search

apache / incubator-kie-tools

Tools for KIE
Apache License 2.0
252 stars 185 forks source link

[vscode-extension-serverless-workflow] Diagram Editor displays eventRef: undefined when action references event #2772

Open domhanak opened 3 days ago

domhanak commented 3 days ago

Summary

When an eventRef is defined for an action in sonataflow, editor display the reference as undefined when hovering over the icon connected to this. Notably there is some behavior if I use older definitions, probably deprecated syntax now.

Environment

VSCode extension on Linux

Steps to reproduce

  1. Import OLD_SYNTAX-event-based-service-invocation.sw.json
  2. Hover over the icon and see Action: eventRef: VetAppointmentInfo AND the file is not syntactically correct as per VSCode syntax checker
  3. Open eventWf.sw.json
  4. Hover over the icon and see Action: eventRef: undefined AND the file is syntactically correct

Actual results

Hover over the icon and see Action: eventRef: undefined

Expected results

Hover over the icon and see Action: eventRef: VetAppointmentInfo OR Potentially show both triggerEventRef and resultEventRef for the state.

Testing

Manual verification is sufficient for this case.

fantonangeli commented 3 days ago

@domhanak @handreyrc This is an issue related to the Diagram Editor and can be replicated on Kubesmarts and the other SonataFlow apps as well. Maybe we can put this bug in "waiting", If we are replacing the Diagram?

domhanak commented 3 days ago

@fantonangeli @handreyrc yea, I reproduced on VSCode, doing it in all of the downstream implementations of swf editor is not possible in reasonable timeframe. What to do with it is your call. Imho this is not big issue as it only impacts the view.

fantonangeli commented 3 days ago

I reproduced on VSCode, doing it in all of the downstream implementations of swf editor is not possible in reasonable timeframe.

Sure @domhanak , I tested it on Kubesmarts and wrote a note to specify we have this issue on all the SonataFlow implementations ;-)