search

apache / incubator-livy

Apache Livy is an open source REST interface for interacting with Apache Spark from anywhere.
https://livy.apache.org/
Apache License 2.0
890 stars 602 forks source link

Fix testing with Python3 #424

Closed mvanderlee closed 1 year ago

mvanderlee commented 1 year ago

What changes were proposed in this pull request?

Fix print statement in tests to be Python 2 and Python 3 compatible. https://github.com/apache/incubator-livy/issues/408

Created an account in JIRA, waiting for approval so I can submit a ticket there as well.

How was this patch tested?

Using the docker build for Spark 3

docker run --rm -it -v $(pwd):/workspace -v $HOME/.m2:/root/.m2 livy-ci mvn package -Pspark3
codecov-commenter commented 1 year ago

Codecov Report

Merging #424 (5271a3a) into master (8b2e29f) will decrease coverage by 36.91%. The diff coverage is n/a.

@@              Coverage Diff              @@
##             master     #424       +/-   ##
=============================================
- Coverage     65.48%   28.58%   -36.91%     
+ Complexity      950      378      -572     
=============================================
  Files           103      103               
  Lines          6062     6062               
  Branches        916      916               
=============================================
- Hits           3970     1733     -2237     
- Misses         1541     3976     +2435     
+ Partials        551      353      -198

see 86 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ksumit commented 1 year ago

Thanks @mvanderlee for your contribution.