Fix test_FP*_arithmetics_YYY.c.in tests

[giorgiozoppi]

I am moving slightly the old test to the cmocka, i have just created cmock test directory with a crypto_context example. What i dont see in the old test coverage is how you coverage the code.

[kealan]

Hi Giorgio

That is done here;

ifneq ($(findstring -DCMAKE_BUILD_TYPE=Coverage,${BUILD_PARAMS}),) mkdir -p target/${BUILD_NAME}/coverage cd target/${BUILD_NAME} && \ cmake $(subst $(dcomma),$(space),${BUILD_PARAMS}) ../.. | tee cmake.log ; test $${PIPESTATUS[0]} -eq 0 && \ export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:./ && \ make | tee make.log ; test $${PIPESTATUS[0]} -eq 0 &&\ lcov --zerocounters --directory . && \ lcov --capture --initial --directory . --output-file coverage/amcl && \ env CTEST_OUTPUT_ONFAILURE=1 make test | tee test.log ; test $${PIPESTATUS[0]} -eq 0 && \ lcov --no-checksum --directory . --capture --output-file coverage/amcl.info && \ lcov --remove coverage/amcl.info "*/test*" --output-file coverage/amcl.info && \ genhtml -o coverage -t "milagro-crypto-c Test Coverage" coverage/amcl.info else

[kealan]

Hi Giogio

What is the reason that you want to move away from ctest to cmocka. I take the approach if it ain't broke don't fix it!

[kealan]

Also, would you mind if we remove cmocka from the master branch and follow the contribution guidelines that I sent in the email? Of course, only if you agree with them. We could branch develop and then add have add-cmocka as a feature with its own issue.

By the way, would you be intererested in starting a new repo maybe called it milagro-crypto-c++ and basing it on the c++ code in the incubator-milagro-crypto?

[kealan]

Hi Giorgio Are you with me removing cmocka from master? I want to set up master and develop branches today that we can then have feature branches off.

[giorgiozoppi]

Yes. Close the ticket. An i put sonar from infra this night as well.

El vie., 14 jun. 2019 a las 17:05, Kealan McCusker (< notifications@github.com>) escribió:

Hi Giorgio Are you with me removing cmocka from master? I want to set up master and develop branches today that we can then have feature branches off.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/apache/incubator-milagro-crypto-c/issues/3?email_source=notifications&email_token=AGPXNMU67JVWH7NYNFWNIW3P2OXTFA5CNFSM4HXYX5MKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXXB6BQ#issuecomment-502144774, or mute the thread https://github.com/notifications/unsubscribe-auth/AGPXNMXJGGYRG2X7SPFMZ3TP2OXTFANCNFSM4HXYX5MA .

-- Life is a chess game - Anonymous.