apache / incubator-milagro-crypto-rust

Apache Milagro Crypto Library - Rust Version

https://milagro.apache.org/

Apache License 2.0

31 stars 19 forks source link

Copying #18

Closed kirk-baird closed 4 years ago

kirk-baird commented 4 years ago

What has been changed

Copying has been replaced with the compiler optimised Clone trait.
Unnecessary variables have been removed where possible.
Constructors have been improved, to take ownership of variables rather than references and copies.

Additional Comments

The speedup is about 5-10% for bls381 signing and verifying and will likely be similar for other curves and protocols.
The compiler optimises out unnecessary memory allocations in clone() resulting in an optimised copy for stack allocated items (which is nearly all structs used in amcl). Thus overall memory consumption should equivalent or at least very comparable.

kealan commented 4 years ago

Hi Kirk There are some conflicts that need resolving for this PR

kirk-baird commented 4 years ago

I've merged develop and resolved all of the conflicts so it is ready for merging.