search

apache / incubator-pagespeed-cpanel

mod_pagespeed module for CPanel WHM
Other
144 stars 50 forks source link

pagespeed +apache 2.4 #6

Closed 1uhost closed 11 years ago

1uhost commented 11 years ago

The cpanel install script will install modspeed.so for apache 2.2 wich fails if you have apache 2.4

igrigorik commented 11 years ago

Hmm, thanks good catch.

The mod_pagespeed packages install two versions of the mod_pagespeed code itself, mod_pagespeed.so for Apache 2.2 and mod_pagespeed_ap24.so for Apache 2.4

Now the question is, should the script just copy both, or do we need to move these selectively?

1uhost commented 11 years ago

It would be good if the script installs both, and then the correct version installed depending on the apache version running. I believe this is what happends if you use the install method suggested on google pagespeed site.

igrigorik commented 11 years ago

Apologies about the delay. Above commit should do the trick - please give it a try!