search

apache / incubator-pagespeed-cpanel

mod_pagespeed module for CPanel WHM
Other
144 stars 50 forks source link

rename .src.rpm file to current file name. #69

Closed mattcheah closed 5 years ago

mattcheah commented 5 years ago

File in this repo: https://github.com/Prajithp/cpanel/raw/master/EA4/ is now named ea-apache24-mod_pagespeed-latest-stable.src.rpm Changed it in the Readme since I got an error when I tried to follow instructions.

oschaaf commented 5 years ago

That makes sense. Did things work out for you after making this change?

mattcheah commented 5 years ago

I actually had an issue with the rpmbuild --rebuild ea-apache24-mod_pagespeed-[file].src.rpm line, and while I tried to figure it out myself, I was having a lot of trouble. I ended up using the below link to install pagespeed. It was just:

yum install ea4-experimental
yum install ea-apache24-mod_pagespeed

https://features.cpanel.net/topic/add-support-for-mod_pagespeed-to-easyapache4

oschaaf commented 5 years ago

Ok, in that case it probably doesn't make sense to merge this, right? Should we close this?

mattcheah commented 5 years ago

Not sure if other people will be able to get the instructions working, but they definitely won't if the URL is pointing to the wrong file. I think it makes more sense to merge it just to make it more likely that it will work for others. There is also another PR that fixes the same problem I think (Sorry, didn't realize before I made mine), so if you want you can close mine and merge the other one.

On Wed, Oct 10, 2018 at 9:41 AM Otto van der Schaaf < notifications@github.com> wrote:

Ok, in that case it probably doesn't make sense to merge this, right? Should we close this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/apache/incubator-pagespeed-cpanel/pull/69#issuecomment-428644027, or mute the thread https://github.com/notifications/unsubscribe-auth/APKXTwWWDQFUfmzfa1Bt9srB0nTYEco_ks5ujiMqgaJpZM4XUHo9 .

oschaaf commented 5 years ago

@mattcheah thanks. I merged https://github.com/apache/incubator-pagespeed-cpanel/pull/48, let's close this one then.