apache / incubator-pagespeed-ngx

Automatic PageSpeed optimization module for Nginx
http://ngxpagespeed.com/
Apache License 2.0
4.37k stars 364 forks source link

How to disable rewriting of Recaptcha ? #1169

Open journeytosilius opened 8 years ago

journeytosilius commented 8 years ago

Hi, do somebody knows a line of code on the pagespeed conf to disable any rewriting of the recaptcha ? After configuring pagespeed the recaptcha is not appearing on my forms.

jmarantz commented 8 years ago

Usually something like pagespeed Disallow /recaptcha/; would help, assuming the Recaptcha resources are all in a path like that.

I don't know any reason offhand why pagespeed should break recaptcha though. It would be good for us to understand the root problem so we can fix it. What symptoms do you see? Are there error messages in the dev-tools console when the recaptcha fails to show up? 404s in the network panel?

-Josh

On Sat, Apr 2, 2016 at 6:34 AM, chromafunk notifications@github.com wrote:

Hi, do somebody knows a line of code on the pagespeed conf to disable any rewriting of the recaptcha ? After configuring pagespeed the recaptcha is not appearing on my forms.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/pagespeed/ngx_pagespeed/issues/1169

journeytosilius commented 8 years ago

Hi ! This is a wordpress install and the recaptcha is integrated on a form plugin.

I have added the line pagespeed Disallow */formcraft-recaptcha/*;

Error on console :

captcha_form_main.js:1 Uncaught ReferenceError: jQuery is not defined(anonymous function) @ captcha_form_main.js:1

When I disable pagespeed the captcha works ... the line of code I have added seems to have no effect. It is the plugin directory where the files for the captcha reside.

jmarantz commented 8 years ago

Don't forget the asterisks around the pattern to match the entire url. On Apr 2, 2016 8:29 AM, "chromafunk" notifications@github.com wrote:

Hi ! This is a wordpress install and the recaptcha is integrated on a form plugin.

I have added the line pagespeed Disallow /formcraft-recaptcha/;

Error on console :

captcha_form_main.js:1 Uncaught ReferenceError: jQuery is not defined(anonymous function) @ captcha_form_main.js:1

When I disable pagespeed the captcha works ... the line of code I have added seems to have no effect. It is the plugin directory where the files for the captcha reside.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/pagespeed/ngx_pagespeed/issues/1169#issuecomment-204707012

journeytosilius commented 8 years ago

There are asterisks, it's Github formatting who's changing it :)

journeytosilius commented 8 years ago

So, any idea ?

jmarantz commented 8 years ago

What filters do you have enabled? On Apr 2, 2016 10:44 AM, "chromafunk" notifications@github.com wrote:

So, any idea ?

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/pagespeed/ngx_pagespeed/issues/1169#issuecomment-204728022

journeytosilius commented 8 years ago

here is the list :

pagespeed EnableFilters collapse_whitespace;

pagespeed EnableFilters remove_comments;

pagespeed EnableFilters remove_quotes;

pagespeed EnableFilters trim_urls;

pagespeed EnableFilters prioritize_critical_css;

pagespeed EnableFilters move_css_to_head;

pagespeed EnableFilters flatten_css_imports;

pagespeed EnableFilters move_css_above_scripts;

pagespeed EnableFilters outline_javascript;

pagespeed EnableFilters outline_css;

pagespeed EnableFilters defer_javascript;

pagespeed EnableFilters insert_dns_prefetch;

pagespeed EnableFilters combine_css;

pagespeed EnableFilters combine_javascript;

pagespeed EnableFilters combine_heads;

pagespeed EnableFilters inline_javascript;

pagespeed EnableFilters inline_css;

pagespeed EnableFilters elide_attributes;

pagespeed EnableFilters convert_meta_tags;

pagespeed EnableFilters lazyload_images;

pagespeed LazyloadImagesAfterOnload on;

pagespeed EnableFilters move_css_to_head;

pagespeed EnableFilters rewrite_images;

pagespeed EnableFilters recompress_images;

pagespeed EnableFilters convert_jpeg_to_progressive;

pagespeed EnableFilters recompress_jpeg;

pagespeed EnableFilters recompress_png;

pagespeed EnableFilters strip_image_color_profile;

pagespeed EnableFilters jpeg_subsampling;

pagespeed EnableFilters convert_png_to_jpeg;

#pagespeed DisableFilters resize_images;

pagespeed EnableFilters inline_import_to_link;

pagespeed EnableFilters rewrite_style_attributes;

pagespeed EnableFilters rewrite_javascript_external;

pagespeed EnableFilters convert_jpeg_to_webp;

pagespeed EnableFilters extend_cache;

pagespeed EnableFilters insert_img_dimensions;

pagespeed EnableFilters resize_mobile_images;

pagespeed EnableFilters sprite_images;

pagespeed EnableFilters canonicalize_javascript_libraries;

pagespeed EnableFilters rewrite_css,sprite_images;

pagespeed DomainRewriteHyperlinks on;

pagespeed EnableFilters rewrite_style_attributes;

pagespeed EnableFilters rewrite_style_attributes_with_url;

pagespeed EnableFilters insert_ga;
morlovich commented 8 years ago

Try turning off defer_javascript

On Sat, Apr 2, 2016 at 11:03 AM, chromafunk notifications@github.com wrote:

here is the list :

pagespeed EnableFilters collapse_whitespace;

pagespeed EnableFilters remove_comments;

pagespeed EnableFilters remove_quotes;

pagespeed EnableFilters trim_urls;

pagespeed EnableFilters prioritize_critical_css;

pagespeed EnableFilters move_css_to_head;

pagespeed EnableFilters flatten_css_imports;

pagespeed EnableFilters move_css_above_scripts;

pagespeed EnableFilters outline_javascript;

pagespeed EnableFilters outline_css;

pagespeed EnableFilters defer_javascript;

pagespeed EnableFilters insert_dns_prefetch;

pagespeed EnableFilters combine_css;

pagespeed EnableFilters combine_javascript;

pagespeed EnableFilters combine_heads;

pagespeed EnableFilters inline_javascript;

pagespeed EnableFilters inline_css;

pagespeed EnableFilters elide_attributes;

pagespeed EnableFilters convert_meta_tags;

pagespeed EnableFilters lazyload_images;

pagespeed LazyloadImagesAfterOnload on;

pagespeed EnableFilters move_css_to_head;

pagespeed EnableFilters rewrite_images;

pagespeed EnableFilters recompress_images;

pagespeed EnableFilters convert_jpeg_to_progressive;

pagespeed EnableFilters recompress_jpeg;

pagespeed EnableFilters recompress_png;

pagespeed EnableFilters strip_image_color_profile;

pagespeed EnableFilters jpeg_subsampling;

pagespeed EnableFilters convert_png_to_jpeg;

pagespeed DisableFilters resize_images;

pagespeed EnableFilters inline_import_to_link;

pagespeed EnableFilters rewrite_style_attributes;

pagespeed EnableFilters rewrite_javascript_external;

pagespeed EnableFilters convert_jpeg_to_webp;

pagespeed EnableFilters extend_cache;

pagespeed EnableFilters insert_img_dimensions;

pagespeed EnableFilters resize_mobile_images;

pagespeed EnableFilters sprite_images;

pagespeed EnableFilters canonicalize_javascript_libraries;

pagespeed EnableFilters rewrite_css,sprite_images;

pagespeed DomainRewriteHyperlinks on;

pagespeed EnableFilters rewrite_style_attributes;

pagespeed EnableFilters rewrite_style_attributes_with_url;

pagespeed EnableFilters insert_ga;

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/pagespeed/ngx_pagespeed/issues/1169#issuecomment-204731020

jmarantz commented 8 years ago

If turning off defer_javascript solves the recaptcha problem, you might be able to try turning it back on, but annotate the recaptcha script with data-pagespeed-no-defer.

E.g.

On Mon, Apr 4, 2016 at 9:24 AM, Maks Orlovich notifications@github.com wrote:

Try turning off defer_javascript

On Sat, Apr 2, 2016 at 11:03 AM, chromafunk notifications@github.com wrote:

here is the list :

pagespeed EnableFilters collapse_whitespace;

pagespeed EnableFilters remove_comments;

pagespeed EnableFilters remove_quotes;

pagespeed EnableFilters trim_urls;

pagespeed EnableFilters prioritize_critical_css;

pagespeed EnableFilters move_css_to_head;

pagespeed EnableFilters flatten_css_imports;

pagespeed EnableFilters move_css_above_scripts;

pagespeed EnableFilters outline_javascript;

pagespeed EnableFilters outline_css;

pagespeed EnableFilters defer_javascript;

pagespeed EnableFilters insert_dns_prefetch;

pagespeed EnableFilters combine_css;

pagespeed EnableFilters combine_javascript;

pagespeed EnableFilters combine_heads;

pagespeed EnableFilters inline_javascript;

pagespeed EnableFilters inline_css;

pagespeed EnableFilters elide_attributes;

pagespeed EnableFilters convert_meta_tags;

pagespeed EnableFilters lazyload_images;

pagespeed LazyloadImagesAfterOnload on;

pagespeed EnableFilters move_css_to_head;

pagespeed EnableFilters rewrite_images;

pagespeed EnableFilters recompress_images;

pagespeed EnableFilters convert_jpeg_to_progressive;

pagespeed EnableFilters recompress_jpeg;

pagespeed EnableFilters recompress_png;

pagespeed EnableFilters strip_image_color_profile;

pagespeed EnableFilters jpeg_subsampling;

pagespeed EnableFilters convert_png_to_jpeg;

pagespeed DisableFilters resize_images;

pagespeed EnableFilters inline_import_to_link;

pagespeed EnableFilters rewrite_style_attributes;

pagespeed EnableFilters rewrite_javascript_external;

pagespeed EnableFilters convert_jpeg_to_webp;

pagespeed EnableFilters extend_cache;

pagespeed EnableFilters insert_img_dimensions;

pagespeed EnableFilters resize_mobile_images;

pagespeed EnableFilters sprite_images;

pagespeed EnableFilters canonicalize_javascript_libraries;

pagespeed EnableFilters rewrite_css,sprite_images;

pagespeed DomainRewriteHyperlinks on;

pagespeed EnableFilters rewrite_style_attributes;

pagespeed EnableFilters rewrite_style_attributes_with_url;

pagespeed EnableFilters insert_ga;

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub < https://github.com/pagespeed/ngx_pagespeed/issues/1169#issuecomment-204731020

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/pagespeed/ngx_pagespeed/issues/1169#issuecomment-205295099

jmaessen commented 8 years ago

[Actually, it may well be jquery that you want to add pagespeed-no-defer to – or potentially both scripts.]

On Mon, Apr 4, 2016 at 9:37 AM, Joshua Marantz notifications@github.com wrote:

If turning off defer_javascript solves the recaptcha problem, you might be able to try turning it back on, but annotate the recaptcha script with data-pagespeed-no-defer.

E.g.

On Mon, Apr 4, 2016 at 9:24 AM, Maks Orlovich notifications@github.com wrote:

Try turning off defer_javascript

On Sat, Apr 2, 2016 at 11:03 AM, chromafunk notifications@github.com wrote:

here is the list :

pagespeed EnableFilters collapse_whitespace;

pagespeed EnableFilters remove_comments;

pagespeed EnableFilters remove_quotes;

pagespeed EnableFilters trim_urls;

pagespeed EnableFilters prioritize_critical_css;

pagespeed EnableFilters move_css_to_head;

pagespeed EnableFilters flatten_css_imports;

pagespeed EnableFilters move_css_above_scripts;

pagespeed EnableFilters outline_javascript;

pagespeed EnableFilters outline_css;

pagespeed EnableFilters defer_javascript;

pagespeed EnableFilters insert_dns_prefetch;

pagespeed EnableFilters combine_css;

pagespeed EnableFilters combine_javascript;

pagespeed EnableFilters combine_heads;

pagespeed EnableFilters inline_javascript;

pagespeed EnableFilters inline_css;

pagespeed EnableFilters elide_attributes;

pagespeed EnableFilters convert_meta_tags;

pagespeed EnableFilters lazyload_images;

pagespeed LazyloadImagesAfterOnload on;

pagespeed EnableFilters move_css_to_head;

pagespeed EnableFilters rewrite_images;

pagespeed EnableFilters recompress_images;

pagespeed EnableFilters convert_jpeg_to_progressive;

pagespeed EnableFilters recompress_jpeg;

pagespeed EnableFilters recompress_png;

pagespeed EnableFilters strip_image_color_profile;

pagespeed EnableFilters jpeg_subsampling;

pagespeed EnableFilters convert_png_to_jpeg;

pagespeed DisableFilters resize_images;

pagespeed EnableFilters inline_import_to_link;

pagespeed EnableFilters rewrite_style_attributes;

pagespeed EnableFilters rewrite_javascript_external;

pagespeed EnableFilters convert_jpeg_to_webp;

pagespeed EnableFilters extend_cache;

pagespeed EnableFilters insert_img_dimensions;

pagespeed EnableFilters resize_mobile_images;

pagespeed EnableFilters sprite_images;

pagespeed EnableFilters canonicalize_javascript_libraries;

pagespeed EnableFilters rewrite_css,sprite_images;

pagespeed DomainRewriteHyperlinks on;

pagespeed EnableFilters rewrite_style_attributes;

pagespeed EnableFilters rewrite_style_attributes_with_url;

pagespeed EnableFilters insert_ga;

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub <

https://github.com/pagespeed/ngx_pagespeed/issues/1169#issuecomment-204731020

— You are receiving this because you commented. Reply to this email directly or view it on GitHub < https://github.com/pagespeed/ngx_pagespeed/issues/1169#issuecomment-205295099

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/pagespeed/ngx_pagespeed/issues/1169#issuecomment-205298482