search

apache / incubator-pagespeed-ngx

Automatic PageSpeed optimization module for Nginx
http://ngxpagespeed.com/
Apache License 2.0
4.37k stars 363 forks source link

make: *** [Makefile:16: modules] Error 2 when compiling module only against patch aarch64 PSOL Libraries #1756

Closed Danrancan closed 2 years ago

Danrancan commented 2 years ago

I am running Ubuntu 20.04 Server, and attempting to compile this module against nginx mainline 1.23.1. Howver, there are errors when using the make command. Please see details below or check https://pastebin.com/qYksN26k.

This is the pagespeed "make" command being compiled against a patched PSOL Library for aarch64 on raspberry pi 4. We are compiling with Nginx Mainline 1.23.1. Locate the patched library at: https://gitlab.com/gusco/ngx_pagespeed_arm. This #make is broken and needs to be updated by developers.

make modules
make -f objs/Makefile modules
make[1]: Entering directory '/usr/local/src/nginx-1.23.1'
cc -c -fPIC -pipe  -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -g -O2 -fdebug-prefix-map=/data/builder/debuild/nginx-1.23.1/debian/debuild-base/nginx-1.23.1=. -fstack-protector-strong -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fPIC  -D_GLIBCXX_USE_CXX11_ABI=0 --std=c++11 -I src/core -I src/event -I src/event/modules -I src/os/unix -I /usr/local/src/incubator-pagespeed-ngx/psol/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/chromium/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/google-sparsehash/src/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/google-sparsehash/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/grpc/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/protobuf/src/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/re2/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/out/Release/obj/gen -I /usr/local/src/incubator-pagespeed-ngx/psol/include/out/Release/obj/gen/protoc_out/instaweb -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/apr/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/aprutil/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/apr/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/aprutil/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/url -I objs -I src/http -I src/http/modules -I src/http/v2 -I src/mail -I src/stream \
    -o objs/addon/src/log_message_handler.o \
    /usr/local/src/incubator-pagespeed-ngx/src/log_message_handler.cc
cc -c -fPIC -pipe  -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -g -O2 -fdebug-prefix-map=/data/builder/debuild/nginx-1.23.1/debian/debuild-base/nginx-1.23.1=. -fstack-protector-strong -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fPIC  -D_GLIBCXX_USE_CXX11_ABI=0 --std=c++11 -I src/core -I src/event -I src/event/modules -I src/os/unix -I /usr/local/src/incubator-pagespeed-ngx/psol/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/chromium/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/google-sparsehash/src/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/google-sparsehash/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/grpc/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/protobuf/src/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/re2/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/out/Release/obj/gen -I /usr/local/src/incubator-pagespeed-ngx/psol/include/out/Release/obj/gen/protoc_out/instaweb -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/apr/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/aprutil/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/apr/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/aprutil/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/url -I objs -I src/http -I src/http/modules -I src/http/v2 -I src/mail -I src/stream \
    -o objs/addon/src/ngx_base_fetch.o \
    /usr/local/src/incubator-pagespeed-ngx/src/ngx_base_fetch.cc
cc -c -fPIC -pipe  -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -g -O2 -fdebug-prefix-map=/data/builder/debuild/nginx-1.23.1/debian/debuild-base/nginx-1.23.1=. -fstack-protector-strong -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fPIC  -D_GLIBCXX_USE_CXX11_ABI=0 --std=c++11 -I src/core -I src/event -I src/event/modules -I src/os/unix -I /usr/local/src/incubator-pagespeed-ngx/psol/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/chromium/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/google-sparsehash/src/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/google-sparsehash/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/grpc/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/protobuf/src/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/re2/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/out/Release/obj/gen -I /usr/local/src/incubator-pagespeed-ngx/psol/include/out/Release/obj/gen/protoc_out/instaweb -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/apr/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/aprutil/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/apr/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/aprutil/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/url -I objs -I src/http -I src/http/modules -I src/http/v2 -I src/mail -I src/stream \
    -o objs/addon/src/ngx_caching_headers.o \
    /usr/local/src/incubator-pagespeed-ngx/src/ngx_caching_headers.cc
cc -c -fPIC -pipe  -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -g -O2 -fdebug-prefix-map=/data/builder/debuild/nginx-1.23.1/debian/debuild-base/nginx-1.23.1=. -fstack-protector-strong -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fPIC  -D_GLIBCXX_USE_CXX11_ABI=0 --std=c++11 -I src/core -I src/event -I src/event/modules -I src/os/unix -I /usr/local/src/incubator-pagespeed-ngx/psol/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/chromium/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/google-sparsehash/src/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/google-sparsehash/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/grpc/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/protobuf/src/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/re2/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/out/Release/obj/gen -I /usr/local/src/incubator-pagespeed-ngx/psol/include/out/Release/obj/gen/protoc_out/instaweb -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/apr/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/aprutil/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/apr/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/aprutil/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/url -I objs -I src/http -I src/http/modules -I src/http/v2 -I src/mail -I src/stream \
    -o objs/addon/src/ngx_event_connection.o \
    /usr/local/src/incubator-pagespeed-ngx/src/ngx_event_connection.cc
cc -c -fPIC -pipe  -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -g -O2 -fdebug-prefix-map=/data/builder/debuild/nginx-1.23.1/debian/debuild-base/nginx-1.23.1=. -fstack-protector-strong -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fPIC  -D_GLIBCXX_USE_CXX11_ABI=0 --std=c++11 -I src/core -I src/event -I src/event/modules -I src/os/unix -I /usr/local/src/incubator-pagespeed-ngx/psol/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/chromium/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/google-sparsehash/src/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/google-sparsehash/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/grpc/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/protobuf/src/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/re2/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/out/Release/obj/gen -I /usr/local/src/incubator-pagespeed-ngx/psol/include/out/Release/obj/gen/protoc_out/instaweb -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/apr/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/aprutil/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/apr/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/aprutil/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/url -I objs -I src/http -I src/http/modules -I src/http/v2 -I src/mail -I src/stream \
    -o objs/addon/src/ngx_fetch.o \
    /usr/local/src/incubator-pagespeed-ngx/src/ngx_fetch.cc
cc -c -fPIC -pipe  -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -g -O2 -fdebug-prefix-map=/data/builder/debuild/nginx-1.23.1/debian/debuild-base/nginx-1.23.1=. -fstack-protector-strong -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fPIC  -D_GLIBCXX_USE_CXX11_ABI=0 --std=c++11 -I src/core -I src/event -I src/event/modules -I src/os/unix -I /usr/local/src/incubator-pagespeed-ngx/psol/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/chromium/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/google-sparsehash/src/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/google-sparsehash/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/grpc/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/protobuf/src/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/re2/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/out/Release/obj/gen -I /usr/local/src/incubator-pagespeed-ngx/psol/include/out/Release/obj/gen/protoc_out/instaweb -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/apr/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/aprutil/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/apr/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/aprutil/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/url -I objs -I src/http -I src/http/modules -I src/http/v2 -I src/mail -I src/stream \
    -o objs/addon/src/ngx_gzip_setter.o \
    /usr/local/src/incubator-pagespeed-ngx/src/ngx_gzip_setter.cc
cc -c -fPIC -pipe  -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -g -O2 -fdebug-prefix-map=/data/builder/debuild/nginx-1.23.1/debian/debuild-base/nginx-1.23.1=. -fstack-protector-strong -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fPIC  -D_GLIBCXX_USE_CXX11_ABI=0 --std=c++11 -I src/core -I src/event -I src/event/modules -I src/os/unix -I /usr/local/src/incubator-pagespeed-ngx/psol/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/chromium/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/google-sparsehash/src/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/google-sparsehash/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/grpc/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/protobuf/src/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/re2/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/out/Release/obj/gen -I /usr/local/src/incubator-pagespeed-ngx/psol/include/out/Release/obj/gen/protoc_out/instaweb -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/apr/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/aprutil/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/apr/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/aprutil/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/url -I objs -I src/http -I src/http/modules -I src/http/v2 -I src/mail -I src/stream \
    -o objs/addon/src/ngx_list_iterator.o \
    /usr/local/src/incubator-pagespeed-ngx/src/ngx_list_iterator.cc
cc -c -fPIC -pipe  -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -g -O2 -fdebug-prefix-map=/data/builder/debuild/nginx-1.23.1/debian/debuild-base/nginx-1.23.1=. -fstack-protector-strong -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fPIC  -D_GLIBCXX_USE_CXX11_ABI=0 --std=c++11 -I src/core -I src/event -I src/event/modules -I src/os/unix -I /usr/local/src/incubator-pagespeed-ngx/psol/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/chromium/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/google-sparsehash/src/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/google-sparsehash/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/grpc/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/protobuf/src/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/re2/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/out/Release/obj/gen -I /usr/local/src/incubator-pagespeed-ngx/psol/include/out/Release/obj/gen/protoc_out/instaweb -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/apr/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/aprutil/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/apr/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/aprutil/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/url -I objs -I src/http -I src/http/modules -I src/http/v2 -I src/mail -I src/stream \
    -o objs/addon/src/ngx_message_handler.o \
    /usr/local/src/incubator-pagespeed-ngx/src/ngx_message_handler.cc
cc -c -fPIC -pipe  -O -W -Wall -Wpointer-arith -Wno-unused-parameter -Werror -g -g -O2 -fdebug-prefix-map=/data/builder/debuild/nginx-1.23.1/debian/debuild-base/nginx-1.23.1=. -fstack-protector-strong -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fPIC  -D_GLIBCXX_USE_CXX11_ABI=0 --std=c++11 -I src/core -I src/event -I src/event/modules -I src/os/unix -I /usr/local/src/incubator-pagespeed-ngx/psol/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/chromium/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/google-sparsehash/src/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/google-sparsehash/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/grpc/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/protobuf/src/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/re2/src -I /usr/local/src/incubator-pagespeed-ngx/psol/include/out/Release/obj/gen -I /usr/local/src/incubator-pagespeed-ngx/psol/include/out/Release/obj/gen/protoc_out/instaweb -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/apr/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/aprutil/src/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/apr/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/third_party/aprutil/gen/arch/linux/aarch64/include -I /usr/local/src/incubator-pagespeed-ngx/psol/include/url -I objs -I src/http -I src/http/modules -I src/http/v2 -I src/mail -I src/stream \
    -o objs/addon/src/ngx_pagespeed.o \
    /usr/local/src/incubator-pagespeed-ngx/src/ngx_pagespeed.cc
/usr/local/src/incubator-pagespeed-ngx/src/ngx_pagespeed.cc: In function ‘ngx_int_t net_instaweb::{anonymous}::ps_set_cache_control(ngx_http_request_t*, char*)’:
/usr/local/src/incubator-pagespeed-ngx/src/ngx_pagespeed.cc:407:36: error: request for member ‘elts’ in ‘r->ngx_http_request_s::headers_out.ngx_http_headers_out_t::cache_control’, which is of pointer type ‘ngx_table_elt_t*’ {aka ‘ngx_table_elt_s*’} (maybe you meant to use ‘->’ ?)
  407 |   if (r->headers_out.cache_control.elts == NULL) {
      |                                    ^~~~
/usr/local/src/incubator-pagespeed-ngx/src/ngx_pagespeed.cc:408:35: error: cannot convert ‘ngx_table_elt_t**’ {aka ‘ngx_table_elt_s**’} to ‘ngx_array_t*’
  408 |     ngx_int_t rc = ngx_array_init(&r->headers_out.cache_control, r->pool,
      |                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                   |
      |                                   ngx_table_elt_t** {aka ngx_table_elt_s**}
In file included from src/core/ngx_core.h:65,
                 from src/http/ngx_http.h:13,
                 from /usr/local/src/incubator-pagespeed-ngx/src/ngx_pagespeed.h:33,
                 from /usr/local/src/incubator-pagespeed-ngx/src/ngx_pagespeed.cc:26:
src/core/ngx_array.h:32:29: note:   initializing argument 1 of ‘ngx_int_t ngx_array_init(ngx_array_t*, ngx_pool_t*, ngx_uint_t, size_t)’
   32 | ngx_array_init(ngx_array_t *array, ngx_pool_t *pool, ngx_uint_t n, size_t size)
      |                ~~~~~~~~~~~~~^~~~~
/usr/local/src/incubator-pagespeed-ngx/src/ngx_pagespeed.cc:415:22: error: cannot convert ‘ngx_table_elt_t**’ {aka ‘ngx_table_elt_s**’} to ‘ngx_array_t*’
  415 |       ngx_array_push(&r->headers_out.cache_control));
      |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                      |
      |                      ngx_table_elt_t** {aka ngx_table_elt_s**}
In file included from src/core/ngx_core.h:65,
                 from src/http/ngx_http.h:13,
                 from /usr/local/src/incubator-pagespeed-ngx/src/ngx_pagespeed.h:33,
                 from /usr/local/src/incubator-pagespeed-ngx/src/ngx_pagespeed.cc:26:
src/core/ngx_array.h:27:35: note:   initializing argument 1 of ‘void* ngx_array_push(ngx_array_t*)’
   27 | void *ngx_array_push(ngx_array_t *a);
      |                      ~~~~~~~~~~~~~^
/usr/local/src/incubator-pagespeed-ngx/src/ngx_pagespeed.cc: In function ‘bool net_instaweb::{anonymous}::ps_get_cache_control(ngx_http_request_t*, GoogleString*)’:
/usr/local/src/incubator-pagespeed-ngx/src/ngx_pagespeed.cc:439:74: error: request for member ‘elts’ in ‘r->ngx_http_request_s::headers_out.ngx_http_headers_out_t::cache_control’, which is of pointer type ‘ngx_table_elt_t*’ {aka ‘ngx_table_elt_s*’} (maybe you meant to use ‘->’ ?)
  439 |   auto ccp = static_cast<ngx_table_elt_t**>(r->headers_out.cache_control.elts);
      |                                                                          ^~~~
/usr/local/src/incubator-pagespeed-ngx/src/ngx_pagespeed.cc:444:59: error: request for member ‘nelts’ in ‘r->ngx_http_request_s::headers_out.ngx_http_headers_out_t::cache_control’, which is of pointer type ‘ngx_table_elt_t*’ {aka ‘ngx_table_elt_s*’} (maybe you meant to use ‘->’ ?)
  444 |   for (ngx_uint_t i = 0; i < r->headers_out.cache_control.nelts; i++) {
      |                                                           ^~~~~
make[1]: *** [objs/Makefile:1975: objs/addon/src/ngx_pagespeed.o] Error 1
make[1]: Leaving directory '/usr/local/src/nginx-1.23.1'
make: *** [Makefile:16: modules] Error 2
oschaaf commented 2 years ago

See https://github.com/apache/incubator-pagespeed-ngx/issues/1749 (closing this as a duplicate -- this was resolved via https://github.com/apache/incubator-pagespeed-ngx/pull/1751)

Danrancan commented 2 years ago

See #1749 (closing this as a duplicate -- this was resolved via #1751)

Dang, I checked out your link and read through the conversations, but I can't find any resolution still. It doesn't seem like anyone actually posted a real solution for compiling correctly. I am a noob so I am sorry if I am missing something. Do you think you could be a bit more specific as to the solution to this? Maybe point me in the right direction? Thanks.

shigechika commented 2 years ago

I am using my PR1750 patch for later nginx-1.23.0. https://github.com/shigechika/nginx-module-pagespeed/blob/master/PR1750.diff

Danrancan commented 2 years ago

I am using my PR1750 patch for later nginx-1.23.0. https://github.com/shigechika/nginx-module-pagespeed/blob/master/PR1750.diff

To actually apply this patch I downloaded the raw file into my git directory and ran git apply /path/to/some-changes.patch. Is the the correct method of applying the patch?

shigechika commented 2 years ago

Do you know how to patch command and it's usage? ex. patch -p1 < PR1750.diff

Danrancan commented 2 years ago

@shigechika No I have never used the patch command. Should I be using that instead of my suggestion? I did end up using git apply command and things compiled correctly. Not sure if I need to go back and use the patch command instead now.

ronilaukkarinen commented 2 years ago

Hello, we just noticed this with nginx-1.23.1 on Ubuntu 20.04, official script:

bash <(curl -f -L -sS https://ngxpagespeed.com/install) \
     --nginx-version latest

Is there going to be a patch in the official version at https://ngxpagespeed.com/install? How to resolve?

We were forced to roll back to the previously installed version for now:

sudo apt-cache showpkg nginx |grep 1.21
sudo apt install nginx=1.21.6-1~focal

And then

bash <(curl -f -L -sS https://ngxpagespeed.com/install) \
     --nginx-version 1.21.6

Please advice, if possible. Referencing issue #1752

oschaaf commented 2 years ago

@ronilaukkarinen I thought that with that last change having landed on master, this problem would have been resolved. But it's not -- the latest-stable tag is used in this install flow (looking at what happens with respect to $NPS_VERSION in that https://ngxpagespeed.com/install script). So it looks like we need to produce a new stable release in order to fix this..

ronilaukkarinen commented 2 years ago

@oschaaf Thank you for the information. So you mean the command will work with --ngx-pagespeed-version set up specifically to latest-stable?

bash <(curl -f -L -sS https://ngxpagespeed.com/install) \
     --nginx-version latest
     --ngx-pagespeed-version latest-stable

We'll test it out in the extra maintenance window next week.

oschaaf commented 2 years ago

@ronilaukkarinen we will need to produce a new stable release before the install script will pick it up like that. It doesn't make sense to try it out as it stands (step one would be the new stable release).

ronilaukkarinen commented 2 years ago

@oschaaf I see. I mistakenly thought there's a separate --latest-stable option that works. But in that case we'll just wait for the next new stable and hold back ngx-pagespeed updates for now. 👍

ronilaukkarinen commented 2 years ago

@oschaaf Any progress?

beobungbu commented 2 years ago

@oschaaf Any update?

ronilaukkarinen commented 2 years ago

FYI, this seems worth trying.

eilandert commented 2 years ago

FYI, this seems worth trying.

The procedure on https://github.com/apache/incubator-pagespeed-ngx/issues/1760 should work, however the PSOL I provide there is compiled on x64 so you need to change the downloadlink for the aarch64 psol

ronilaukkarinen commented 1 year ago

@oschaaf Any progress?

@eilandert We decided not to try your procedure in production... we have Ubuntu 20.04.5 LTS (focal), x86_64.

This should be fixed.