search

apache / incubator-pagespeed-ngx

Automatic PageSpeed optimization module for Nginx
http://ngxpagespeed.com/
Apache License 2.0
4.37k stars 363 forks source link

Combine javascript #987

Open huglester opened 9 years ago

huglester commented 9 years ago

Hello,

I have this in nginx config:

    # combine multiple JavaScript files into one
    pagespeed EnableFilters combine_javascript;

but the html output still looks like this:

<script type="text/javascript" src="/assets/default/js/jquery.js,q1342650369.pagespeed.jm.kYkDJlOiOC.js"></script>
<script type="text/javascript" src="/assets/default/js/cufon-yui.js,q1315426929.pagespeed.jm.JU1Ajqs9kC.js"></script>
<script type="text/javascript" src="/assets/default/js/Myriad_Pro_300-Myriad_Pro_italic_300.font.js,q1315426927.pagespeed.jm.eKDYA5e_dK.js"></script>
<script type="text/javascript" src="/assets/default/js/Myriad_Pro_400-Myriad_Pro_700-Myriad_Pro_italic_400-Myriad_Pro_italic_700.font.js,q1315426931.pagespeed.jm.HCQIZmMRNF.js"></script>

Maybe it is because we had smth limilar to: /assets/default/js/jquery.js?unit_timestamp

or is there anything else we can do, to enable concatenation of JS files?

Thanks

jeffkaufman commented 9 years ago

Could you load your page with the debug filter enabled, and look at the html source? PageSpeed will add comments explaining why it didn't make various optimizations.

http://www.example.com?PageSpeedFilters=+debug