search

apache / incubator-ponymail-foal

Apache Pony Mail Foal (Next Generation Suite)
https://ponymail.apache.org
Apache License 2.0
25 stars 14 forks source link

Flag which dkim ids contain a lid #116

Closed sebbASF closed 2 years ago

sebbASF commented 3 years ago

https://github.com/apache/incubator-ponymail-foal/blob/94e3efc9f27cb6d1bee3bbbfb74961bf7d7da7bd/tools/plugins/dkim_id.py#L394

The DKIM generator includes the lid in the hash output if it differs from the list-id in the message. Such ids are therefore dependent on context which is not present in any email sources, and cannot be regenerated without knowledge of the LID that was used.

If such ids were flagged in some way so they could be distinguished from ids derived solely from the email source, it might reduce the amount of data needed to ensure all ids can be regenerated. Even if such context is lost, it would at least indicate which ids cannot be regenerated without that information.

In any case it might be useful to include a Version identifier at the start of each id in case any adjustments have to be made.

sebbASF commented 2 years ago

I no longer think it would help to know whether the list-id is included in the hash. Especially since #113 means that it is always included. If it is necessary to recreate ids, the original list-id needs to be known (whether embedded or provided)