apache / incubator-seata

:fire: Seata is an easy-to-use, high-performance, open source distributed transaction solution.
https://seata.apache.org/
Apache License 2.0
25.25k stars 8.77k forks source link

optimize: add support for configuring exposeProxy in GlobalTransactionScanner #6566

Closed wanghongzhou closed 3 months ago

wanghongzhou commented 4 months ago

Ⅰ. Description of this PR

This PR introduces changes related to the exposeProxy attribute handling.

Ⅱ. Does this pull request fix one issue?

Yes, this pull request addresses the issue reported in 6562

Ⅲ. Why don't you add test cases (unit test/integration test)?

As this PR is primarily about configuring the exposeProxy attribute, which is more of a configuration change rather than functional changes in the code logic, adding test cases does not apply directly.

Ⅳ. Describe how to verify it

To verify the changes introduced by this PR, follow these steps:

  1. Review the modifications made in the codebase, particularly the addition of the exposeProxy attribute.
  2. Ensure that the new attribute is properly configured and its value is correctly reflected in the relevant components.
  3. Validate the behavior of the application to confirm that the exposeProxy attribute is functioning as expected.

Ⅴ. Special notes for reviews

The changes made in this PR primarily focus on adding support for configuring the exposeProxy attribute. It ensures that the exposeProxy setting is correctly applied in the context of the GlobalTransactionScanner to facilitate the proper functioning of annotations like @GlobalTransactional. The exposeProxy attribute allows obtaining the proxy object, enabling annotations to function correctly in scenarios where method calls within the same class are involved.

funky-eyes commented 4 months ago

/home/runner/work/incubator-seata/incubator-seata/compatible/src/main/java/io/seata/spring/annotation/GlobalTransactionScanner.java:[97,46] incompatible types: int cannot be converted to boolean

wanghongzhou commented 4 months ago

/home/runner/work/incubator-seata/incubator-seata/compatible/src/main/java/io/seata/spring/annotation/GlobalTransactionScanner.java:[97,46] incompatible types: int cannot be converted to boolean

Resolved