search

apache / incubator-seata

:fire: Seata is an easy-to-use, high-performance, open source distributed transaction solution.
https://seata.apache.org/
Apache License 2.0
25.08k stars 8.73k forks source link

test: Improve the test case coverage of [sqlparser] module to 70% #6608

Open traitsisgiorgos opened 3 weeks ago

traitsisgiorgos commented 3 weeks ago

Ⅰ. Describe what this PR did

fix #6508

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

traitsisgiorgos commented 3 weeks ago

@slievrly @funky-eyes Hi, can you review my PR?

funky-eyes commented 5 days ago

LGTM

ok, let's run the CI workflow once to see the outcome.

codecov-commenter commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.40%. Comparing base (933b492) to head (880b104). Report is 28 commits behind head on 2.x.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/apache/incubator-seata/pull/6608/graphs/tree.svg?width=650&height=150&src=pr&token=tbmHt2ZfxO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/incubator-seata/pull/6608?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## 2.x #6608 +/- ## ============================================ - Coverage 51.13% 50.40% -0.74% - Complexity 5317 5721 +404 ============================================ Files 950 1039 +89 Lines 33448 35895 +2447 Branches 4048 4275 +227 ============================================ + Hits 17103 18092 +989 - Misses 14666 16002 +1336 - Partials 1679 1801 +122 ``` [see 140 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6608/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
xjlgod commented 13 hours ago

Hi, I use your code to verify test coverage in my local idea env. Its test coverage is not high enough, can you add more unit tests? image