bugfix: fix the issue of xaEnded not being reset

apache / incubator-seata

:fire: Seata is an easy-to-use, high-performance, open source distributed transaction solution.

https://seata.apache.org/

Apache License 2.0

25.08k stars 8.73k forks source link

bugfix: fix the issue of xaEnded not being reset #6627

Closed tanyaofei closed 1 week ago

tanyaofei commented 2 weeks ago

[ ] I have registered the PR changes.

Ⅰ. Describe what this PR did

用来判断当前是否执行过 XA End 的上下文变量 xaEnded 应当在 cleanXABranchContext 中重置而不是在 close 中

Ⅱ. Does this pull request fix one issue?

fixes #6492

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

tanyaofei commented 1 week ago

LGTM 请登记pr至2.x.md中 Please log the PR in 2.x.md

请问2.1已经发了吗，可以合到2.1去吗，这次的修复要跟着上次那个PR一起发版，不然可能会有问题

funky-eyes commented 1 week ago

LGTM 请登记pr至2.x.md中 Please log the PR in 2.x.md

请问2.1已经发了吗，可以合到2.1去吗，这次的修复要跟着上次那个PR一起发版，不然可能会有问题

这个问题出现的概率比较低，而且seata的connectionproxyxa这个connection被放到连接池里复用的概率也很低，除非有datasource去包装seata的datasourceproxyxa进行归还到连接池，否则这个connectionproxyxa对象是一次性的。所以放到2.2没什么太大问题

funky-eyes commented 1 week ago

@tanyaofei 请把你的钉钉号，通过邮件发送到我的邮箱jianbin@apache.org ，我将邀请你加入seata社区开发者群中，以便沟通

tanyaofei commented 1 week ago

jianbin@apache.org

已发送