apache / incubator-seata

:fire: Seata is an easy-to-use, high-performance, open source distributed transaction solution.
https://seata.apache.org/
Apache License 2.0
25.25k stars 8.77k forks source link

Optimize: unified use of "org.apache.seata.common.ConfigurationKeys" #6771

Closed yangli-stu closed 1 month ago

yangli-stu commented 1 month ago

Why you need it?

Is your feature request related to a problem? Please describe in details

在core与config模块中,都有一个@Deprecated注解标识的“ConfigurationKeys”配置类,而该类都是继承于“org.apache.seata.common.ConfigurationKeys”类,且无其它任何额外作用。从可维护性上看,可以考虑移除core与config模块中的“ConfigurationKeys”类,改为统一使用“org.apache.seata.common.ConfigurationKeys”。 image image

How it could be?

A clear and concise description of what you want to happen. You can explain more about input of the feature, and output of it.

移除core与config模块中过期的“ConfigurationKeys”类,全局替换下改为统一使用“org.apache.seata.common.ConfigurationKeys”。

Other related information

Add any other context or screenshots about the feature request here.

funky-eyes commented 1 month ago

全局替换主要考虑到可能有其它人的pr与这个全局改动的pr有代码冲突,所以现在的原则是通过review时避免pr使用旧版的ConfigurationKeys,和提交pr时,比如修改到了A类,顺便将其修正。 When performing a global replacement, it's important to consider that other people's pull requests (PRs) might conflict with the global change. Therefore, the current principle is to avoid using the old ConfigurationKeys in PRs during the review process, and to make the necessary corrections when submitting a PR, such as modifying class A and making the required updates.

yangli-stu commented 1 month ago

好的,那我把这个issue关闭掉~

全局替换主要考虑到可能有其它人的pr与这个全局改动的pr有代码冲突,所以现在的原则是通过review时避免pr使用旧版的ConfigurationKeys,和提交pr时,比如修改到了A类,顺便将其修正。 When performing a global replacement, it's important to consider that other people's pull requests (PRs) might conflict with the global change. Therefore, the current principle is to avoid using the old ConfigurationKeys in PRs during the review process, and to make the necessary corrections when submitting a PR, such as modifying class A and making the required updates.