apache / incubator-seata

:fire: Seata is an easy-to-use, high-performance, open source distributed transaction solution.
https://seata.apache.org/
Apache License 2.0
25.25k stars 8.77k forks source link

optimize: use curator instead of zkclient in config model #6779

Closed leizhiyuan closed 3 weeks ago

leizhiyuan commented 1 month ago

Ⅰ. Describe what this PR did

fiees #6772

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

test case

Ⅴ. Special notes for reviews

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 52.21239% with 54 lines in your changes missing coverage. Please review.

Project coverage is 52.30%. Comparing base (fa6bdda) to head (4328e05). Report is 2 commits behind head on 2.x.

Files with missing lines Patch % Lines
...apache/seata/config/zk/ZookeeperConfiguration.java 52.67% 47 Missing and 6 partials :warning:
.../apache/seata/config/ConfigurationChangeEvent.java 0.00% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/apache/incubator-seata/pull/6779/graphs/tree.svg?width=650&height=150&src=pr&token=tbmHt2ZfxO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/incubator-seata/pull/6779?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## 2.x #6779 +/- ## ============================================ - Coverage 52.38% 52.30% -0.09% - Complexity 6384 6407 +23 ============================================ Files 1081 1083 +2 Lines 37617 37848 +231 Branches 4464 4493 +29 ============================================ + Hits 19706 19796 +90 - Misses 15961 16081 +120 - Partials 1950 1971 +21 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata/pull/6779?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [.../apache/seata/config/ConfigurationChangeEvent.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6779?src=pr&el=tree&filepath=config%2Fseata-config-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fconfig%2FConfigurationChangeEvent.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29uZmlnL3NlYXRhLWNvbmZpZy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9jb25maWcvQ29uZmlndXJhdGlvbkNoYW5nZUV2ZW50LmphdmE=) | `96.29% <0.00%> (-3.71%)` | :arrow_down: | | [...apache/seata/config/zk/ZookeeperConfiguration.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6779?src=pr&el=tree&filepath=config%2Fseata-config-zk%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fconfig%2Fzk%2FZookeeperConfiguration.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29uZmlnL3NlYXRhLWNvbmZpZy16ay9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvY29uZmlnL3prL1pvb2tlZXBlckNvbmZpZ3VyYXRpb24uamF2YQ==) | `42.03% <52.67%> (ø)` | | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6779/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
funky-eyes commented 1 month ago

@leizhiyuan Please fix the ci problem.

funky-eyes commented 3 weeks ago

Error: Failures: Error: ZkConfigurationTest.testPutConfig:83 expected: but was: [INFO] Error: Tests run: 3, Failures: 1, Errors: 0, Skipped: 0 [INFO]

leizhiyuan commented 3 weeks ago

Error: Failures: Error: ZkConfigurationTest.testPutConfig:83 expected: but was: [INFO] Error: Tests run: 3, Failures: 1, Errors: 0, Skipped: 0 [INFO]

It seems to have something to do with the environment.,Local mac has always passed.,I'll find a Linux machine to run it.

image
leizhiyuan commented 3 weeks ago
image

run ok in linux。。