apache / incubator-seata

:fire: Seata is an easy-to-use, high-performance, open source distributed transaction solution.
https://seata.apache.org/
Apache License 2.0
25.37k stars 8.79k forks source link

feature: add grpc serializer #6992

Closed PleaseGiveMeTheCoke closed 2 weeks ago

PleaseGiveMeTheCoke commented 2 weeks ago

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

https://github.com/apache/incubator-seata/issues/6990

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 4.76190% with 20 lines in your changes missing coverage. Please review.

Project coverage is 52.66%. Comparing base (835ef47) to head (5de2f37). Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ache/seata/serializer/protobuf/GrpcSerializer.java 0.00% 17 Missing :warning:
.../apache/seata/core/rpc/netty/grpc/GrpcEncoder.java 0.00% 2 Missing :warning:
.../apache/seata/core/rpc/netty/grpc/GrpcDecoder.java 0.00% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/apache/incubator-seata/pull/6992/graphs/tree.svg?width=650&height=150&src=pr&token=tbmHt2ZfxO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/incubator-seata/pull/6992?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) ```diff @@ Coverage Diff @@ ## 2.x #6992 +/- ## ============================================ - Coverage 52.67% 52.66% -0.02% - Complexity 6572 6573 +1 ============================================ Files 1125 1126 +1 Lines 39924 39942 +18 Branches 4676 4678 +2 ============================================ + Hits 21031 21034 +3 - Misses 16897 16912 +15 Partials 1996 1996 ``` | [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata/pull/6992?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...g/apache/seata/core/serializer/SerializerType.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6992?src=pr&el=tree&filepath=core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fcore%2Fserializer%2FSerializerType.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvY29yZS9zZXJpYWxpemVyL1NlcmlhbGl6ZXJUeXBlLmphdmE=) | `69.56% <100.00%> (+1.38%)` | :arrow_up: | | [.../apache/seata/core/rpc/netty/grpc/GrpcDecoder.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6992?src=pr&el=tree&filepath=core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fcore%2Frpc%2Fnetty%2Fgrpc%2FGrpcDecoder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvY29yZS9ycGMvbmV0dHkvZ3JwYy9HcnBjRGVjb2Rlci5qYXZh) | `0.00% <0.00%> (ø)` | | | [.../apache/seata/core/rpc/netty/grpc/GrpcEncoder.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6992?src=pr&el=tree&filepath=core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fcore%2Frpc%2Fnetty%2Fgrpc%2FGrpcEncoder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvY29yZS9ycGMvbmV0dHkvZ3JwYy9HcnBjRW5jb2Rlci5qYXZh) | `0.00% <0.00%> (ø)` | | | [...ache/seata/serializer/protobuf/GrpcSerializer.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6992?src=pr&el=tree&filepath=serializer%2Fseata-serializer-protobuf%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Fserializer%2Fprotobuf%2FGrpcSerializer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2VyaWFsaXplci9zZWF0YS1zZXJpYWxpemVyLXByb3RvYnVmL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zZWF0YS9zZXJpYWxpemVyL3Byb3RvYnVmL0dycGNTZXJpYWxpemVyLmphdmE=) | `0.00% <0.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6992/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)