search

apache / incubator-stormcrawler

A scalable, mature and versatile web crawler based on Apache Storm
https://stormcrawler.apache.org/
Apache License 2.0
879 stars 258 forks source link

files in jars have odd dates #1300

Open pjfanning opened 4 days ago

pjfanning commented 4 days ago

I checked the 3.1.0 RC jars and the files in stormcrawler-core-3.1.0.jar all had this date.

07-04-2024

I am in favour of reproducible builds meaning that files in jar may not have today's date but this date is confusing. Many reproducible builds just go with 01-01-1970 dates or some date hardcoded in build but that might reflect some date around the release (as long as the date is hardcoded in the source release so that all builds have this date regardless of when the build with that release is run.

rzo1 commented 4 days ago

Don't think we set it explicitly, so working towards reproducable builds would be good anyway.

pjfanning commented 4 days ago

How did we end up with 7 April or 4 July as the date? (I'm not sure if the date in the file is in International or in US format)

rzo1 commented 4 days ago

Guess it is a side effect from Apache Parent. Didn't dig into it though.