search

apache / incubator-stormcrawler

A scalable, mature and versatile web crawler based on Apache Storm
https://stormcrawler.apache.org/
Apache License 2.0
887 stars 262 forks source link

URLFilters show logging as if ParseFilters #886

Closed GerbenKD closed 3 years ago

GerbenKD commented 3 years ago

I'm not sure whether the following line is intentional.

https://github.com/DigitalPebble/storm-crawler/blob/eb735b4f704e86ccdf004ca4dee107f331fad2a4/core/src/main/java/com/digitalpebble/stormcrawler/util/Configurable.java#L33

When debugging my URLFilters it was confusing that they were logging as ParseFilters because of the line above.

cheers,

Gerben

jnioche commented 3 years ago

Good catch. Overlooked that when I refactored the code. Not sure if there is a way of getting the actual class implementing the interface. Alternatively could rewrite into LoggerFactory.getLogger(Configurable.class);

GerbenKD commented 3 years ago

I've never seen that with the actual implementing class. For me it would make most sense to log from Configurable.class.

Gerben