Closed lvyanquan closed 2 years ago
Most open-source projects skip test when package: mvnw clean package -DskipTests
Yeah, it's not a bug that blocks main process and will have no effort on use of the product. But I think unit test is still a way to improve code quality and code review. ---- separate line ---- Sorry. Then I found we actually skip these two modules in gitHub action check, in action of "Maven Package Test", we use
Run mvn -B test -pl '!streampark-plugin/streampark-jvm-profiler,!streampark-console/streampark-console-service' -am
So this class won't block the gitHub action of test, but I think it's still unnecessary.
I will close this issue later if no other opinion is proposed.
Thanks for your feedback, look at it this way, there is really no need this testcase
Search before asking
What happened
Failed to execute 'mvnw clean package' under the directory of this project, the execution will be blocked as following:
StreamPark Version
1.2.4
Java Version
1.8
Flink Version
1.14
Scala Version of Flink
2.12
Error Exception
this method doesn't exit.
Screenshots
Are you willing to submit PR?
Code of Conduct