search

apache / incubator-streampark

Make stream processing easier! Easy-to-use streaming application development framework and operation platform.
https://streampark.apache.org/
Apache License 2.0
3.91k stars 1.01k forks source link

drop lockutilsTest failed #4036

Closed Mrart closed 1 month ago

Mrart commented 2 months ago

What changes were proposed in this pull request

drop lockutilsTest failed

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Mrart commented 2 months ago

I have never heard of any open source project doing this. Cancelling the test if it fails is unreasonable. You should fix the problem until the test passes. I personally refuse to merge this PR.

This code has not been used in the project for the time being. I tried to fix it, but there is still a problem. Let's add an issue to follow up this ut test.

Mrart commented 2 months ago

I have never heard of any open source project doing this. Cancelling the test if it fails is unreasonable. You should fix the problem until the test passes. I personally refuse to merge this PR.

This ut test now prevents the merging of all our PRS.

caicancai commented 2 months ago

I have never heard of any open source project doing this. Cancelling the test if it fails is unreasonable. You should fix the problem until the test passes. I personally refuse to merge this PR.

This code has not been used in the project for the time being. I tried to fix it, but there is still a problem. Let's add an issue to follow up this ut test.

You should fix the test and merge the PR. This is the case for many open source projects. I even agree not to delete this test and merge this PR, but I don't agree to delete this test directly. Can you describe what's wrong with this test? Why does the test fail?

wolfboys commented 2 months ago

Thanks for your contribution, but the current PR is a duplicate of this PR

wolfboys commented 1 month ago

Thanks for your contribution. The issue has been resolved.