apache / incubator-teaclave-sgx-sdk

Apache Teaclave (incubating) SGX SDK helps developers to write Intel SGX applications in the Rust programming language, and also known as Rust SGX SDK.
https://teaclave.apache.org
Apache License 2.0
1.17k stars 264 forks source link

thirdparty libs wishlist for ipfs support #63

Open brenzi opened 5 years ago

brenzi commented 5 years ago

For supporting ipfs content validation in sgx, the following libs would be helpful:

https://github.com/multiformats/rust-multihash https://github.com/multiformats/rust-multibase https://github.com/multiformats/rust-cid

Any chance you could port these? They're using other crypto libs than are already ported, so I fear it's not straightforward I'd be happy to contribute an example for their usage

elichai commented 5 years ago

The first one should be very easy to convert to no-std I would've just make a PR to add official support.

The second is a bit interesting because base-x lazely uses vec inside of it instead of accepting buffered data from the outside. So either you can help him make it no-std or fork it and replace the std.

At the end these are pretty easy to do. If they should be in third_party that's for @dingelish to determine :)

Maybe I'll try to contribute a guide on converting libraries, it's pretty easy once you get the hang of it (although some times it's too much libraries to maintain, so you should always try to stick to no-std ones)

dingelish commented 5 years ago

I have an idea of pushing support of this rust-sgx-sdk to all projects in RustCrypto. I'll try to contact the authors this week. Let's keep this issue open.

elichai commented 5 years ago

Sounds interesting. If you achieve some sort of a standard for adding rust-sgx-sdk support to libraries (preferably using some sort of a target) I will start making PRs to a lot of projects too

tarcieri commented 5 years ago

@dingelish I'm happy to help with upstreaming stuff to https://github.com/RustCrypto

dingelish commented 5 years ago

Thanks Tony! I'll keep you updated :)