apache / incubator-teaclave-trustzone-sdk

Teaclave TrustZone SDK enables safe, functional, and ergonomic development of trustlets.
https://teaclave.apache.org
Apache License 2.0
203 stars 58 forks source link

Add missing identifiers for RSA and elliptic curves #125

Closed samitolvanen closed 2 months ago

samitolvanen commented 2 months ago

optee-utee is missing a few algorithm and attribute identifiers required for implementing AOSP KeyMint TA [1]. Add the missing RSA and ECC constants.

[1] https://android.googlesource.com/platform/system/keymint/

DemesneGH commented 2 months ago

Merged, thanks! BTW, If your TA doesn't require the std (means all third-party crates it has imported don't need std) it's recommended to use our no-std branch which is more up-to-date with OPTEE version and has better performance. If you're interested in it see here: https://github.com/apache/incubator-teaclave-trustzone-sdk/tree/no-std

samitolvanen commented 2 months ago

Yes, we've been using the no-std branch. Do you cherry-pick changes from master to the no-std branch, or is there something I should do to get this merged there too?

DemesneGH commented 2 months ago

Do you cherry-pick changes from master to the no-std branch

I'll do that. It's nice to open the PR on no-std branch the next time, thanks!

DemesneGH commented 2 months ago

synced to https://github.com/apache/incubator-teaclave-trustzone-sdk/commit/a2491dbc1c4471f9a35618887b67d3832a2ba6ec