apache / incubator-teaclave

Apache Teaclave (incubating) is an open source universal secure computing platform, making computation on privacy-sensitive data safe and simple.
https://teaclave.apache.org
Apache License 2.0
757 stars 159 forks source link

Missing schema in "teaclave_xxx_service" advertised address #706

Closed hiroki-chen closed 1 year ago

hiroki-chen commented 1 year ago

The configuration file runtime.config.toml in docker folder seems to be improperly written because I found the following key value pairs

[internal_endpoints]
authentication = { listen_address = "0.0.0.0:17776", advertised_address = "teaclave-authentication-service:17776" }
management     = { listen_address = "0.0.0.0:17777", advertised_address = "teaclave-management-service:17777" }
storage        = { listen_address = "0.0.0.0:17778", advertised_address = "teaclave-storage-service:17778" }
access_control = { listen_address = "0.0.0.0:17779", advertised_address = "teaclave-access-control-service:17779" }
execution      = { listen_address = "0.0.0.0:17770", advertised_address = "teaclave-execution-service:17770" }
scheduler      = { listen_address = "0.0.0.0:17780", advertised_address = "teaclave-scheduler-service:17780" }

would trigger errors when I tried to run the Teaclave service with docker-compose. Sample error:

teaclave-execution-service         | [ERROR teaclave_execution_service_enclave::ecall] Failed to run service: Missing schema in "teaclave_scheduler_service" advertised address

It could be fixed by adding the prefix https://, i.e., it should be advertised_address = "https://teaclave-authentication-service:17776". For your information, I built Teaclave in simulation mode.

Thank you for your attention, and I can create a PR if you need it :)

BTW, the docker runtime config file does not match that under config directory.

henrysun007 commented 1 year ago

@GeminiCarrie Could you please help fix this issue?

GeminiCarrie commented 1 year ago

Yes, it is indeed necessary to add the URI scheme to the advertised address before starting the service. It's great if you can submit a PR to fix it. Thank you so much!

hiroki-chen commented 1 year ago

@GeminiCarrie Thank you for the quick reply. I've created a PR to fix this :)