[Bug] Incorrect capacity check in Server#LocalStorage - Githubissues

apache / incubator-uniffle

Uniffle is a high performance, general purpose Remote Shuffle Service.

https://uniffle.apache.org/

Apache License 2.0

382 stars 149 forks source link

[Bug] Incorrect capacity check in Server#LocalStorage #1071

Open zuston opened 1 year ago

zuston commented 1 year ago

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

Describe the bug

When uniffle shuffle-servers colocate with other services (like Hadoop HDFS data), they shares the same mounted disks.

If so, the current capacity checking is wrong, it only will check the uniffle's data used size instead of using the free disk size.

Affects Version(s)

master

Uniffle Server Log Output

No response

Uniffle Engine Log Output

No response

Uniffle Server Configurations

No response

Uniffle Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

[X] Yes I am willing to submit a PR!

lifeSo commented 10 months ago

Maybe this PR could be close occording to conversation:

https://github.com/apache/incubator-uniffle/pull/1072#issuecomment-1855541678

https://github.com/apache/incubator-uniffle/pull/1337

@jerqi