search

apache / incubator-uniffle

Uniffle is a high performance, general purpose Remote Shuffle Service.
https://uniffle.apache.org/
Apache License 2.0
361 stars 138 forks source link

[Improvement] Unit tests support mocking the ShuffleServerNettyHandler class #1810

Open rickyma opened 2 weeks ago

rickyma commented 2 weeks ago

Code of Conduct

Search before asking

What would you like to be improved?

Unit tests support mocking the ShuffleServerNettyHandler class in order to better cover the business code for the netty part.

We can search for TODO skip validating for GRPC_NETTY, needs to mock ShuffleServerNettyHandler in our codes.

How should we improve?

No response

Are you willing to submit PR?

rickyma commented 1 week ago

This is really important in Netty mode. Anyone is welcome to pick this up.

rickyma commented 2 days ago

This is really important in Netty mode. Anyone is welcome to pick this up.

When running in prod, we currently use Netty mode due to https://github.com/apache/incubator-uniffle/issues/1651, so this issue is very important. Because we lack the ability to test Netty business codes using UTs. If you are interested, I can assign this issue to you. That will be of great help.

@maobaolong

maobaolong commented 2 days ago

@rickyma Will take a look at this issue, thank you!