apache / incubator-uniffle

Uniffle is a high performance, general purpose Remote Shuffle Service.
https://uniffle.apache.org/
Apache License 2.0
387 stars 149 forks source link

[MINOR]improvement(client/server): (RemoteMerger) Refactor to use mergeContext collect the arguments related #2195

Closed maobaolong closed 1 month ago

maobaolong commented 1 month ago

What changes were proposed in this pull request?

Refactor to use mergeContext collect the arguments related to remote merger

Why are the changes needed?

Does this PR introduce any user-facing change?

No.

How was this patch tested?

No need, just refactor.

github-actions[bot] commented 1 month ago

Test Results

 2 926 files  +31   2 926 suites  +31   6h 10m 0s :stopwatch: + 11m 40s  1 049 tests + 6   1 047 :white_check_mark: + 7   2 :zzz: ±0  0 :x:  - 1  13 045 runs  +72  13 015 :white_check_mark: +73  30 :zzz: ±0  0 :x:  - 1 

Results for commit 4106224c. ± Comparison against base commit 9f8951fe.

This pull request removes 6 and adds 12 tests. Note that renamed tests count towards both. ``` org.apache.uniffle.test.DynamicConfTest ‑ dynamicConfTest org.apache.uniffle.test.HadoopConfTest ‑ hadoopConfTest org.apache.uniffle.test.LargeSorterTest ‑ largeSorterTest org.apache.uniffle.test.RMWordCountTest ‑ wordCountTest org.apache.uniffle.test.SecondarySortTest ‑ secondarySortTest org.apache.uniffle.test.WordCountTest ‑ wordCountTest ``` ``` org.apache.uniffle.test.DynamicConfTest ‑ dynamicConfTest{ClientType}[1] org.apache.uniffle.test.DynamicConfTest ‑ dynamicConfTest{ClientType}[2] org.apache.uniffle.test.HadoopConfTest ‑ hadoopConfTest{ClientType}[1] org.apache.uniffle.test.HadoopConfTest ‑ hadoopConfTest{ClientType}[2] org.apache.uniffle.test.LargeSorterTest ‑ largeSorterTest{ClientType}[1] org.apache.uniffle.test.LargeSorterTest ‑ largeSorterTest{ClientType}[2] org.apache.uniffle.test.RMWordCountTest ‑ wordCountTest{ClientType}[1] org.apache.uniffle.test.RMWordCountTest ‑ wordCountTest{ClientType}[2] org.apache.uniffle.test.SecondarySortTest ‑ secondarySortTest{ClientType}[1] org.apache.uniffle.test.SecondarySortTest ‑ secondarySortTest{ClientType}[2] … ```

:recycle: This comment has been updated with latest results.

jerqi commented 1 month ago

@zhengchenyu Could you help me review this pull request?

zhengchenyu commented 1 month ago

@zhengchenyu Could you help me review this pull request?

Okay, I will review this PR. But I want to review until #2173 is finished. #2173 will bring performance improvement, but also many changes.

maobaolong commented 1 month ago

@jerqi Would you like to take a look?

maobaolong commented 1 month ago

@jerqi @zhengchenyu Thanks for your review!