[Improvement] Remove the ShuffleBlockInfo used in the communication between client and server via handleSendShuffleDataRequest. - Githubissues

apache / incubator-uniffle

Uniffle is a high performance, general purpose Remote Shuffle Service.

https://uniffle.apache.org/

Apache License 2.0

387 stars 149 forks source link

[Improvement] Remove the ShuffleBlockInfo used in the communication between client and server via handleSendShuffleDataRequest. #2201

Open lwllvyb opened 1 month ago

lwllvyb commented 1 month ago

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Search before asking

[X] I have searched in the issues and found no similar issues.

What would you like to be improved?

Remove the ShuffleBlockInfo used in the communication between client and server via handleSendShuffleDataRequest.
The code byteBuf.writeInt(shuffleBlockInfo.getLength()); in encodeShuffleBlockInfo is redundant, because the block data length has been encoded in shuffleBlockInfo.copyDataTo(byteBuf)

Related PR: #2181

How should we improve?

No response

Are you willing to submit PR?

[X] Yes I am willing to submit a PR!