apache / incubator-uniffle

Uniffle is a high performance, general purpose Remote Shuffle Service.
https://uniffle.apache.org/
Apache License 2.0
387 stars 149 forks source link

[#2207] feat(dashboard): Add the write information of appinfo in Shuflle Server heartbeat #2208

Closed lwllvyb closed 1 month ago

lwllvyb commented 1 month ago

What changes were proposed in this pull request?

Add the write information of appinfo in Shuflle Server heartbeat

Why are the changes needed?

Fix: #2207

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Locally

github-actions[bot] commented 1 month ago

Test Results

 2 926 files  +31   2 926 suites  +31   5h 57m 13s :stopwatch: + 10m 8s  1 043 tests ± 0   1 041 :white_check_mark: + 1   2 :zzz: ±0  0 :x:  - 1  13 033 runs  +60  13 003 :white_check_mark: +61  30 :zzz: ±0  0 :x:  - 1 

Results for commit 9c62de93. ± Comparison against base commit f9b4c0e0.

maobaolong commented 1 month ago

@lwllvyb It would be easy to understand your changes if you could use the curl http://localhost:19976/api/app/appInfos | python -m json.tool to query the appInfos and paste it to the description.

Or another way to show how to get the appInfo from the coordinator after this PR?

lwllvyb commented 1 month ago

@lwllvyb It would be easy to understand your changes if you could use the curl http://localhost:19976/api/app/appInfos | python -m json.tool to query the appInfos and paste it to the description.

Or another way to show how to get the appInfo from the coordinator after this PR?

@lwllvyb It would be easy to understand your changes if you could use the curl http://localhost:19976/api/app/appInfos | python -m json.tool to query the appInfos and paste it to the description.

Or another way to show how to get the appInfo from the coordinator after this PR?

This PR is derived from another PR #2063 . I split the PR #2063 into several smaller PRs that are easier to review, and this one of them.

I will commit another PR #2215 (I have created an issue #2211 ) which depends on this PR. I don't know if this is the right approach.

After submitting the PR related to #2211, the dashboard will show the application info as follows.

image