apache / incubator-uniffle

Uniffle is a high performance, general purpose Remote Shuffle Service.
https://uniffle.apache.org/
Apache License 2.0
387 stars 149 forks source link

[#2222] feat(server): Introduce LocalFileWriterFactory and LocalFileNioWriter impl #2223

Closed maobaolong closed 3 weeks ago

maobaolong commented 3 weeks ago

What changes were proposed in this pull request?

Why are the changes needed?

Fix: #2222

Does this PR introduce any user-facing change?

How was this patch tested?

image

This is shown that it could avoid create huge amount of object leverage this PR

github-actions[bot] commented 3 weeks ago

Test Results

 2 926 files  +41   2 926 suites  +41   6h 20m 17s ⏱️ + 18m 48s  1 088 tests ± 0   1 086 ✅ + 2   2 💤 ±0  0 ❌ ±0  13 630 runs  +70  13 600 ✅ +72  30 💤 ±0  0 ❌ ±0 

Results for commit 8b2e18be. ± Comparison against base commit 6380c080.

:recycle: This comment has been updated with latest results.

maobaolong commented 3 weeks ago

@rickyma Thanks for your review and suggestion, addressed it, PTAL.

codecov-commenter commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 45.23810% with 23 lines in your changes missing coverage. Please review.

Project coverage is 53.09%. Comparing base (34bf686) to head (ccae3ef). Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...iffle/storage/handler/impl/LocalFileNioWriter.java 0.00% 19 Missing :warning:
...e/storage/handler/impl/LocalFileWriterFactory.java 42.85% 3 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2223 +/- ## ============================================ + Coverage 51.84% 53.09% +1.25% - Complexity 2864 3113 +249 ============================================ Files 469 473 +4 Lines 23879 24924 +1045 Branches 1966 2369 +403 ============================================ + Hits 12380 13234 +854 - Misses 10726 10799 +73 - Partials 773 891 +118 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

maobaolong commented 3 weeks ago

@rickyma Thanks for your review!

maobaolong commented 3 weeks ago

@jerqi Thanks for your suggestion, I renamed the config key to rss.storage.localFileWriter.class, PTAL.

maobaolong commented 3 weeks ago

@jerqi PTAL

maobaolong commented 3 weeks ago

@jerqi @rickyma Thanks for your review.