Closed maobaolong closed 3 weeks ago
2 926 files +41 2 926 suites +41 6h 20m 17s ⏱️ + 18m 48s 1 088 tests ± 0 1 086 ✅ + 2 2 💤 ±0 0 ❌ ±0 13 630 runs +70 13 600 ✅ +72 30 💤 ±0 0 ❌ ±0
Results for commit 8b2e18be. ± Comparison against base commit 6380c080.
:recycle: This comment has been updated with latest results.
@rickyma Thanks for your review and suggestion, addressed it, PTAL.
Attention: Patch coverage is 45.23810%
with 23 lines
in your changes missing coverage. Please review.
Project coverage is 53.09%. Comparing base (
34bf686
) to head (ccae3ef
). Report is 6 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@rickyma Thanks for your review!
@jerqi Thanks for your suggestion, I renamed the config key to rss.storage.localFileWriter.class
, PTAL.
@jerqi PTAL
@jerqi @rickyma Thanks for your review.
What changes were proposed in this pull request?
Why are the changes needed?
Fix: #2222
Does this PR introduce any user-facing change?
rss.storage.localFileWriterClass
How was this patch tested?
This is shown that it could avoid create huge amount of object leverage this PR