Closed maobaolong closed 2 weeks ago
2 926 files +31 2 926 suites +31 6h 11m 19s ⏱️ + 14m 50s 1 088 tests ± 0 1 086 ✅ + 1 2 💤 ±0 0 ❌ ±0 13 630 runs +60 13 600 ✅ +61 30 💤 ±0 0 ❌ ±0
Results for commit 88b2b77b. ± Comparison against base commit 680f96a1.
:recycle: This comment has been updated with latest results.
Will the config option be written back to the configuration file?
@jerqi No, reconfig through restapi is a temporarily way, this can be use when we tuning the configs or in an emergency to avoid restart server.
@jerqi No, reconfig through restapi is a temporarily way, this can be use when we tuning the configs or in an emergency to avoid restart server.
Maybe you should add temporarily
key word in the URL.
curl -X POST http://localhost:19948/api/shuffleServer/confOps/update
->
curl -X POST http://localhost:19948/api/shuffleServer/confOps/tempUpdate
Is this ok? @jerqi
curl -X POST http://localhost:19948/api/shuffleServer/confOps/update
->curl -X POST http://localhost:19948/api/shuffleServer/confOps/tempUpdate
Is this ok? @jerqi
curl -X POST http://localhost:19948/api/shuffleServer/confOps/update
->curl -X POST http://localhost:19948/api/shuffleServer/confOps/tempUpdate
Is this ok? @jerqi
http://localhost:19948/api/shuffleserver/confops/temp/update may be better. URI is't case sentive. I prefer not using camel style in the URI.
@jerqi As this is a use case of rest api update, I start another PR to improve the conf update
rest api.
https://github.com/apache/incubator-uniffle/pull/2235 This is the improvement PR about update conf api
@jerqi Thanks for your review on this PR, merge it
What changes were proposed in this pull request?
Support dynamic update the conf of high/low water mark.
Why are the changes needed?
It can be easy to tune the server online without restart leverage this.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Tested Locally.
server.log