apache / incubator-uniffle

Uniffle is a high performance, general purpose Remote Shuffle Service.
https://uniffle.apache.org/
Apache License 2.0
387 stars 149 forks source link

[#2241] improvement(server): Introduce storage flush operation timeout cancel to avoid disk hang #2247

Closed zuston closed 1 week ago

zuston commented 2 weeks ago

What changes were proposed in this pull request?

Introduce storage flush operation timeout cancel to avoid disk hang

Why are the changes needed?

For #2241

Does this PR introduce any user-facing change?

Yes. rss.server.storage.flushOptionTimeoutSec is introduced, the default value = -1 means this timeout cancel will not be activated by default

How was this patch tested?

unit tests and existing tests.

codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 66.66667% with 13 lines in your changes missing coverage. Please review.

Project coverage is 52.43%. Comparing base (10c02cd) to head (130b3bb). Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
...pache/uniffle/server/DefaultFlushEventHandler.java 30.76% 8 Missing and 1 partial :warning:
.../uniffle/common/future/CompletableFutureUtils.java 80.95% 2 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2247 +/- ## ============================================ + Coverage 52.15% 52.43% +0.27% + Complexity 3517 2959 -558 ============================================ Files 550 467 -83 Lines 31672 22185 -9487 Branches 2707 2033 -674 ============================================ - Hits 16518 11632 -4886 + Misses 14098 9815 -4283 + Partials 1056 738 -318 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago

Test Results

 2 956 files  +15   2 956 suites  +15   6h 10m 50s ⏱️ - 6m 29s  1 092 tests + 1   1 090 ✅ + 1   2 💤 ±0  0 ❌ ±0  13 685 runs  +15  13 655 ✅ +15  30 💤 ±0  0 ❌ ±0 

Results for commit 92ae0798. ± Comparison against base commit 4db95c3c.

:recycle: This comment has been updated with latest results.