apache / incubator-wayang

Apache Wayang(incubating) is the first cross-platform data processing system.
https://wayang.incubator.apache.org/
Apache License 2.0
174 stars 70 forks source link

naive kmeans operator on sparkml #356

Closed joker-star-l closed 8 months ago

joker-star-l commented 9 months ago

I implemented a naive kmeans operator on sparkml, and add two test cases. It is still in development. Maybe you can give me some advice on the code and design. Thanks!

2pk03 commented 8 months ago

Hi @joker-star-l. thank you! The license check failed, please add the proper license header into:

wayang-commons/wayang-basic/src/main/java/org/apache/wayang/basic/operators/KMeansOperator.java
wayang-platforms/wayang-spark/code/main/java/org/apache/wayang/spark/mapping/ml/KMeansMapping.java
wayang-platforms/wayang-spark/code/main/java/org/apache/wayang/spark/operators/ml/SparkKMeansOperator.java
wayang-platforms/wayang-spark/code/main/java/org/apache/wayang/spark/plugin/SparkMLPlugin.java
wayang-platforms/wayang-spark/code/test/java/org/apache/wayang/spark/operators/SparkKMeansOperatorTest.java 
joker-star-l commented 8 months ago

Hi @joker-star-l. thank you! The license check failed, please add the proper license header into:

wayang-commons/wayang-basic/src/main/java/org/apache/wayang/basic/operators/KMeansOperator.java
wayang-platforms/wayang-spark/code/main/java/org/apache/wayang/spark/mapping/ml/KMeansMapping.java
wayang-platforms/wayang-spark/code/main/java/org/apache/wayang/spark/operators/ml/SparkKMeansOperator.java
wayang-platforms/wayang-spark/code/main/java/org/apache/wayang/spark/plugin/SparkMLPlugin.java
wayang-platforms/wayang-spark/code/test/java/org/apache/wayang/spark/operators/SparkKMeansOperatorTest.java 

Ok.

2pk03 commented 8 months ago

@joker-star-l - thank you! Can you please have a look why the compile check fails: https://github.com/apache/incubator-wayang/actions/runs/6666101299/job/18117721148?pr=356#step:6:4675 ?

joker-star-l commented 8 months ago

@joker-star-l - thank you! Can you please have a look why the compile check fails: https://github.com/apache/incubator-wayang/actions/runs/6666101299/job/18117721148?pr=356#step:6:4675 ?

Sorry, I forgot to add spark-ml dependency for java8 and I have fix it.