search

apache / incubator-weex

Apache Weex (Incubating)
https://weex.apache.org
Apache License 2.0
13.75k stars 1.82k forks source link

refine code structure for eagle #3161

Closed jianhan-he closed 4 years ago

weex-bot commented 4 years ago
Fails
:no_entry_sign: Code file weex_core/Source/core/bridge/eagle_bridge.h has cn source code.
Warnings
:warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/org/apache/weex/WXSDKInstance.java without metion it in commit message. You'd better add '@notdanger' in your commit log.
:warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/org/apache/weex/bridge/WXBridge.java without metion it in commit message. You'd better add '@notdanger' in your commit log.
:warning: Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/org/apache/weex/bridge/WXModuleManager.java without metion it in commit message. You'd better add '@notdanger' in your commit log.
:warning: No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md
:warning: Current pr not bind the milestone
:warning: If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue

Generated by :no_entry_sign: dangerJS against 2ded50b6759fdee8627870f15b1e6fc8dad060f0

cnryb commented 4 years ago

The Travis CI build failed, can you fix it ?

YorkShen commented 4 years ago

@jianhan-he Wait a minute, maybe we could solve it togehter.

YorkShen commented 4 years ago

It works well now, there is some network problem between the server of TravisCI and Maven repo.

chenzefeng09 commented 4 years ago

What is eagle ?

YorkShen commented 4 years ago

A C++ implementation of Vue.js, and they are trying to decouple the existing interface to a new repo.