search

apache / incubator-xtable

Apache XTable (incubating) is a cross-table converter for lakehouse table formats that facilitates interoperability across data processing systems and query engines.
https://xtable.apache.org/
Apache License 2.0
768 stars 119 forks source link

Website header add ASF menu #388

Open wuchunfu opened 3 months ago

wuchunfu commented 3 months ago

Website header add ASF menu

xtable-bot commented 3 months ago

CI report:

Bot commands @xtable-bot supports the following commands: - `@xtable-bot run azure` re-run the last Azure build
wuchunfu commented 3 months ago

@the-other-tim-brown @zabetak @vinothchandar @jcamachor PTAL, thanks

wuchunfu commented 3 months ago

I am building the site locally but I don't see the new menu. Can you please share the steps that you did to test this change?

@zabetak Thank you for your review. The red box represents the effect of the modifications I made this time image

zabetak commented 3 months ago

@wuchunfu Is the ASF drop-down menu present in the main Home page? It doesn't show up for me.

wuchunfu commented 3 months ago

@wuchunfu Is the ASF drop-down menu present in the main Home page? It doesn't show up for me.

@zabetak Oh, it's my fault. When I run the npm run start command, it can appear, but now the organization of this document doesn't seem to be a standard docusaurus. The index page now looks like a fixed index.html file. Normal docusaurus can be generated automatically. Do you need to adjust it to standard docusaurus?

zabetak commented 3 months ago

Not sure what needs to be done but the way it is right now I guess the index.html must be edited manually to add the new menu.

wuchunfu commented 3 months ago

Not sure what needs to be done but the way it is right now I guess the index.html must be edited manually to add the new menu.

Yes, I will finish this work later, but this method is a bit troublesome. Actually, the top menu docusaurus will be automatically generated, and I plan to optimize this content later