apache / incubator-xtable

Apache XTable (incubating) is a cross-table converter for lakehouse table formats that facilitates interoperability across data processing systems and query engines.
https://xtable.apache.org/
Apache License 2.0
768 stars 119 forks source link

Rename and replace 'client' in classes and comments #407

Closed the-other-tim-brown closed 3 months ago

the-other-tim-brown commented 3 months ago

Important Read

What is the purpose of the pull request

Addresses #406 Renames the SourceClient, TargetClient, and OneTableClient to ConversionSource, ConversionTarget, and ConversionController.

Brief change log

This pull request is a trivial rework / code cleanup without any test coverage.

the-other-tim-brown commented 3 months ago

Raising as a draft. I need to confirm the demo still works after this.

the-other-tim-brown commented 3 months ago

cc @lmccay

the-other-tim-brown commented 3 months ago

I have confirmed that the demo is still working after these updates

xtable-bot commented 3 months ago

CI report:

Bot commands @xtable-bot supports the following commands: - `@xtable-bot run azure` re-run the last Azure build
the-other-tim-brown commented 3 months ago

Tested the manual conversion flow documented in the README as well to confirm all the values are properly renamed in the yamls, I will merge this now.