apache / incubator-xtable

Apache XTable (incubating) is a cross-table converter for lakehouse table formats that facilitates interoperability across data processing systems and query engines.
https://xtable.apache.org/
Apache License 2.0
919 stars 147 forks source link

Added support for dynamically getting delta table features #428

Open ForeverAngry opened 6 months ago

ForeverAngry commented 6 months ago

Important Read

To address: Issue #354

What is the purpose of the pull request

This pull request implements dynamically capturing the min reader and writer version of a target delta table, based on its table details.

Brief change log

Verify this pull request

This pull request is already covered by existing tests, i think...

This is my first PR to an open source project - i was a bit unsure of how to do the unit test for this change. Any pointers or insight would be welcomed :) !

the-other-tim-brown commented 5 months ago

@ForeverAngry we've gone through some module renaming, can you pull in the latest changes from main to pick up the path changes?

ghost commented 5 months ago

CI report:

Bot commands @xtable-bot supports the following commands: - `@xtable-bot run azure` re-run the last Azure build
ForeverAngry commented 5 months ago

Sure. Also, I'm not really versed in writing java test. So I'm flying a bit blind here, in terms if those are correct or not. Any pointers would be appreciated.

On Sun, May 26, 2024, 8:00 PM Tim Brown @.***> wrote:

@ForeverAngry https://github.com/ForeverAngry we've gone through some module renaming, can you pull in the latest changes from main to pick up the path changes?

— Reply to this email directly, view it on GitHub https://github.com/apache/incubator-xtable/pull/428#issuecomment-2132440434, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOXHQZAFKJ5YM6FMSGFNLUTZEJZQZAVCNFSM6AAAAABG65VQ36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZSGQ2DANBTGQ . You are receiving this because you were mentioned.Message ID: @.***>

ForeverAngry commented 5 months ago

@ForeverAngry we've gone through some module renaming, can you pull in the latest changes from main to pick up the path changes?

@the-other-tim-brown sure. Also, I don't have a lot of experience writing java test. Can you point out what I need to fix, to please the bot :)?

the-other-tim-brown commented 5 months ago

@ForeverAngry we've gone through some module renaming, can you pull in the latest changes from main to pick up the path changes?

@the-other-tim-brown sure. Also, I don't have a lot of experience writing java test. Can you point out what I need to fix, to please the bot :)?

There were some issues with the test infra but those should be resolved now. After pushing your next commit, it should kick off a new run and I'll take a look at the results