fix licencse check

[the-other-tim-brown]

Important Read

• Please ensure the GitHub issue is mentioned at the beginning of the PR

What is the purpose of the pull request

(For example: This pull request implements the sync for delta format.)

Brief change log

(for example:)

• Fixed JSON parsing error when persisting state
• Added unit tests for schema evolution

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

• Added integration tests for end-to-end.
• Added HudiSchemaEvolutionTest to verify the change.
• Manually verified the change by running a job locally.

[the-other-tim-brown]

@wuchunfu can you help me to get the license check passing?

[xtable-bot]

CI report:

• e55151f83af136d6eb60698db65a97877560c5c6 Azure: SUCCESS

Bot commands

@xtable-bot supports the following commands: - `@xtable-bot run azure` re-run the last Azure build

[charlesy6]

Having both spotless check and skywalking-eys in the same project is not a good practice, because their behaviors are not the same, what do you think? @the-other-tim-brown @sagarlakshmipathy @wuchunfu

[the-other-tim-brown]

@charlesy6 the intention was that the skywalking check would find anything not covered by the spotless plugin since the spotless plugin requires you to define rules for different file types not covered by default. If there is something that better fits that need, let me know.

[daragu]

@the-other-tim-brown, I agree with @charlesy6's point that there is no need to introduce the skywalking into xtable project. and it is also not used in projects such as hudi, paimon, flink...

We can use mvn validate or mvn spotless:check command to execute check commod on plugins such as spotless, enforcer.

E.g

name: CI mvn validate

concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}
  cancel-in-progress: true

on:
  push:
    branches:
      - "main"

  pull_request:
    branches:
      - "main"

jobs:
  build:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4

      - uses: actions/setup-java@v4
        with:
          java-version: '11'
          distribution: 'temurin'

      - name: validate plugin
        run: mvn validate

[the-other-tim-brown]

@the-other-tim-brown, I agree with @charlesy6's point that there is no need to introduce the skywalking into xtable project. and it is also not used in projects such as hudi, paimon, flink...

We can use mvn validate or mvn spotless:check command to execute check commod on plugins such as spotless, enforcer.

E.g

name: CI mvn validate

concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}
  cancel-in-progress: true

on:
  push:
    branches:
      - "main"

  pull_request:
    branches:
      - "main"

jobs:
  build:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4

      - uses: actions/setup-java@v4
        with:
          java-version: '11'
          distribution: 'temurin'

      - name: validate plugin
        run: mvn validate

@daragu how do we catch new file types being added without licenses? That is not currently possible with spotless. mvn validate is just part of the Maven lifecycle, you will run that as part of install https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html

[daragu]

thanks @the-other-tim-brown, let me think again.

[daragu]

hi @the-other-tim-brown, when a new type of file is added to the repo, it will be detected by the maven rat plugin automatically. it seems that we can close this pr now.