apache / incubator-xtable

Apache XTable (incubating) is a cross-table converter for lakehouse table formats that facilitates interoperability across data processing systems and query engines.
https://xtable.apache.org/
Apache License 2.0
919 stars 147 forks source link

The Hudi example at https://xtable.apache.org/docs/hms#register-the-target-table-in-hive-metastore is not the command for HMS sync. #455

Open alberttwong opened 5 months ago

alberttwong commented 5 months ago

Search before asking

Please describe the bug 🐞

Per hudi-hive-sync docs, since we're talking about HMS sync, isn't the command something like

./run_sync_tool.sh  \
--metastore-uris 'thrift://hive-metastore:9083' \
--partitioned-by city \
--base-path 's3a://warehouse/people' \
--database hudi_db \
--table people \
--sync-mode hms 

Are you willing to submit PR?

Code of Conduct

vinishjail97 commented 5 months ago

Hudi Hive Sync has three modes - JDBC, HMS and HIVEQL. https://github.com/apache/hudi/blob/master/hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HoodieHiveSyncClient.java#L94

I have added few comments on your PR for docs improvements.