search

apache / incubator-xtable

Apache XTable (incubating) is a cross-table converter for lakehouse table formats that facilitates interoperability across data processing systems and query engines.
https://xtable.apache.org/
Apache License 2.0
919 stars 147 forks source link

[486] Change artifact name to incubator-xtable and Add deploy plugin to mvn #498

Closed vinishjail97 closed 3 months ago

vinishjail97 commented 3 months ago

Important Read

What is the purpose of the pull request

https://github.com/apache/incubator-xtable/issues/486 According to apache guidelines, we need to prefix the "incubator" prefix for all artifacts deployed to maven. This is how the bundled jar will look like in maven central repository when uploaded.

<dependency>
<groupId>org.apache.xtable</groupId>
<artifactId>incubator-xtable-utilities</artifactId>
<version>0.1.0-rc1</version>
<classifier>bundled</classifier>
</dependency>

Brief change log

(for example:)

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

Validated the below command by uploading the rc-1 artifacts to staging repository. mvn deploy -Prelease -DskipTests -DdeployArtifacts=true

vinishjail97 commented 3 months ago

Squashed everything into a single commit.

jcamachor commented 3 months ago

Sorry for the late response, I was OOF. Thanks, @vinishjail97, for putting the PR together. Could you share the ASF guidelines you are referring to? AFAIK the common practice is adding the -incubating suffix to the release version until the project graduates to TLP, rather than changing the artifact names (which makes sense so any consumer can update the version without changing the artifact ID all over). From a quick look at other incubating projects, that seem to be the practice that they are following. Also cc'ing @zabetak and @jbonofre in case they have any insights about this.

vinishjail97 commented 3 months ago

The Incubator policies applies two additional constraints to podlings for their releases. They are repeated here for clarity only. - Release artifacts must include incubating in the final file name - Release artifacts must include one of two disclaimers

I was refereeing to these guidelines, reading it again looks like you may be right. I misunderstood this sentence. Release artifacts must include incubating in the final file name

jcamachor commented 3 months ago

Yes, looking at the artifacts of other incubating projects, version looks like <version>-incubating.