Closed guitcastro closed 3 months ago
Should we add some readme about how to use this dockerfile?
Yes, that's how I am using, but you probably should deploy the image somewhere. I could create a PR with a workflow to publish on github container register, if you agree.
docker run \
-v ./xtable/config.yml:/xtable/config.yml \
-v ./xtable/core-site.xml:/xtable/core-site.xml \
-v ./xtable/catalog.yml:/xtable/catalog.yml \
registry.gitlab.com/pedalin/xtable-docker-image:4420d2b6 \
--datasetConfig /xtable/config.yml --hadoopConfig /xtable/core-site.xml --icebergCatalogConfig xtable/catalog.yml
Should we add some readme about how to use this dockerfile?
Yes, that's how I am using, but you probably should deploy the image somewhere. I could create a PR with a workflow to publish on github container register, if you agree.
docker run \ -v ./xtable/config.yml:/xtable/config.yml \ -v ./xtable/core-site.xml:/xtable/core-site.xml \ -v ./xtable/catalog.yml:/xtable/catalog.yml \ registry.gitlab.com/pedalin/xtable-docker-image:4420d2b6 \ --datasetConfig /xtable/config.yml --hadoopConfig /xtable/core-site.xml --icebergCatalogConfig xtable/catalog.yml
@guitcastro can you update the README with this as an option for building and running? I am imagining users that are not setup with java locally could benefit from this.
I will check where we can publish the images, we are currently doing our first release as part of the incubator program
@the-other-tim-brown Right, I will update the Readme!
Continue on #506
What is the purpose of the pull request
Create a docker file to run the project
Brief change log
Verify this pull request
This pull request is a trivial rework / code cleanup without any test coverage.