add DISCLAIMER to META-INF in jars

apache / incubator-xtable

Apache XTable (incubating) is a cross-table converter for lakehouse table formats that facilitates interoperability across data processing systems and query engines.

https://xtable.apache.org/

Apache License 2.0

919 stars 147 forks source link

add DISCLAIMER to META-INF in jars #532

Closed pjfanning closed 2 months ago

pjfanning commented 2 months ago

Feature Request / Improvement

You add LICENSE and NOTICE to the META-INF in your jars but many Incubator projects also put their DISCLAIMER in the jar. I'm not 100% sure this is required but it may be a norm.

Are you willing to submit PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

vinishjail97 commented 2 months ago

We are currently using DISCLAIMER-WIP for the project, we plan to eliminate the missed requirements and move to DISCLAIMER file in the next upcoming releases.

In our release guide, we do have this validation to check for DISCLAIMER-WIP file in source distribution, I will submit a PR to include it in the jar as well. Is this a requirement for incubating projects only ? https://github.com/apache/incubator-xtable/blob/main/release/scripts/validate_staged_release.sh#L127

pjfanning commented 2 months ago

Only Incubating projects have DISCLAIMERS.

vinishjail97 commented 2 months ago

@rangareddy will be working on this.