search

apache / incubator-xtable

Apache XTable (incubating) is a cross-table converter for lakehouse table formats that facilitates interoperability across data processing systems and query engines.
https://xtable.apache.org/
Apache License 2.0
919 stars 147 forks source link

[551] Include slf4j in LICENSE file #567

Closed vinishjail97 closed 3 weeks ago

vinishjail97 commented 4 weeks ago

Important Read

What is the purpose of the pull request

Doubled checked all dependencies, found sl4j bundled in the distribution and jar but it uses an MIT license.

Following the guide here -> https://infra.apache.org/licensing-howto.html#permissive-deps

Brief change log

(for example:)

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

the-other-tim-brown commented 4 weeks ago

@vinishjail97 Lombok was updated to a provided scope, do we still need to include it here?

vinishjail97 commented 4 weeks ago

@vinishjail97 Lombok was updated to a provided scope, do we still need to include it here?

Yes that's correct, will remove it.

vinishjail97 commented 3 weeks ago

Some projects have separate LICENSE files in git for source and binary distribution and they include the appropriate one for each case. It might be OK to have one for both but in that case you will have redundant information in one place or the other.

Moreover, if you include the java LICENSE file in every .jar file then you are saying to consumers that SLF4J is included everywhere which might be misleading.

@zabetak Are you suggesting we add a new version of the LICENSE file with slf4j for xtable-hudi-support-extensions ? I have looked at other projects and they don't seem to follow this pattern. If any project follows this, can you share the pom.xml configuration for overriding the LICENSE content for a module, I couldn't find it through apache github search.

zabetak commented 3 weeks ago

@vinishjail97 Can you clarify what exactly are we trying to fix with this LICENSE update? Is this targeting the xtable-hudi-support-extensions_2.12-0.2.0-SNAPSHOT-bundled.jar? This particular jar contains lots of 3rd-party code so slf4j may not be the only thing that we need to mention.

zabetak commented 3 weeks ago

For the record, I think you can use the https://maven.apache.org/plugins/maven-resources-plugin/ to include a specific LICENSE/NOTICE inside the jar. I think that if you simply create the desired LICENSE file under the src/main/resources/META-INF of the desired module it will be included automatically when creating the jar.

vinishjail97 commented 3 weeks ago

@zabetak Yes I have created a separate PR to address the contents of xtable-hudi-support-extensions_2.12-0.2.0-SNAPSHOT-bundled.jar

https://github.com/apache/incubator-xtable/pull/572

vinishjail97 commented 3 weeks ago

Closing this as it's no longer needed. https://github.com/apache/incubator-xtable/pull/572