search

apache / infrastructure-actions

Apache infrastructure
https://infrastructure.apache.org/
1 stars 3 forks source link

toc2.py - spurious file? #20

Open sebbASF opened 5 months ago

sebbASF commented 5 months ago

The toc2.py file was added as part of an unrelated commit:

https://github.com/apache/infrastructure-actions/commit/350141f6e4eb9fbc7f890ab2e761b21782da40bf

It looks like it might have been a mistake.

dfoulks1 commented 5 months ago

petri uses toc2

sebbASF commented 5 months ago

AFAICT the only difference is a change in the __str__ method; surely the two could be combined somehow?

sebbASF commented 5 months ago

petri has its own copy of the plugin, so the copy is not needed here.

It does not make sense to house project-specific versions of plugins in the shared actions repository. If it turns out that some customisation is needed by several projects, then it would be better to do this via the settings file (as is done for asfdata and asfrun etc).

sebbASF commented 5 months ago

See #52 - this obviates the need for toc2.py