search

apache / infrastructure-actions

Apache infrastructure
https://infrastructure.apache.org/
1 stars 3 forks source link

CURRENTYEAR needs to be dynamically generated #8

Closed sebbASF closed 5 months ago

sebbASF commented 5 months ago

In the existing Pelican builds, CURRENTYEAR is regenerated every time the site is built.

However generate_settings replaces the variable reference ([year]) with a fixed value:

https://github.com/apache/infrastructure-actions/blob/50ca5458f5964fe051c745aa3e9a4cdf12077c0d/pelican/migration/generate_settings.py#L46

dfoulks1 commented 5 months ago

it looks like we should be able to safely omit CURRENTYEAR from pelicanconf.py: https://docs.getpelican.com/en/latest/settings.html

sebbASF commented 5 months ago

Are you sure:

https://github.com/search?q=repo%3Aapache%2Fwww-site%20CURRENTYEAR&type=code

sebbASF commented 5 months ago

Note: it's trivial to fix

dfoulks1 commented 5 months ago

if it's a trivial fix I'm not opposed, but why not just fix the templates?

gstein commented 5 months ago

Please provide a PR if this concerns you.

sebbASF commented 5 months ago

if it's a trivial fix I'm not opposed, but why not just fix the templates?

My view is that updates to software should strive for compatibility to minimise unnecessary downstream disruption. Sometimes it is necessary to introduce a breaking change, but that should only be done if really necessary.